test: split test-esm-loader-hooks #61374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
esm
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61374 +/- ##
==========================================
+ Coverage 88.51% 88.53% +0.01%
==========================================
Files 704 704
Lines 208739 208793 +54
Branches 40274 40314 +40
==========================================
+ Hits 184770 184858 +88
+ Misses 15968 15914 -54
- Partials 8001 8021 +20 🚀 New features to boost your workflow:
|
Previously whenever one of the test case fails in the CI, it barely logged anything useful in the CI and it was difficult to nail down the specific failing case with a local reproduction, especially when the test fixutre is inline JavaScript. This patch: - Puts all the inline JavaScript in on-disk fixtures so that they can be re-run easily. - Split the tests into individual files so that it's easier to nail down the failure - Use spawnSyncAndAssert which logs useful information when the child process does not behave as expected. - Rename the tests as module-hooks/test-async-loader-hooks-* because they belong to the module hooks test suite and are not esm-specific.
joyeecheung
force-pushed
the
split-loader-tests
branch
from
4e1d1e3 to
92c1cbc
Compare
marco-ippolito
approved these changes
Jan 14, 2026
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
joyeecheung
added
request-ci
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 3da4dce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously whenever one of the test case fails in the CI, it barely logged anything useful in the CI and it was difficult to nail down the specific failing case with a local reproduction, especially when the test fixutre is inline JavaScript. This patch:
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-01-13.md
cc @RafaelGSS @marco-ippolito