Skip to content

Conversation

@robinvw1
Copy link

@robinvw1 robinvw1 commented Dec 9, 2025

Using globstar in glob pattern prevents dot (hidden) files from being matched

Fixes: #56321

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Dec 9, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2025
@nodejs-github-bot
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (e172be2) to head (b0b8df3).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/fs/glob.js 75.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61012      +/-   ##
==========================================
+ Coverage   88.51%   88.53%   +0.01%     
==========================================
  Files         703      703              
  Lines      208432   208448      +16     
  Branches    40195    40204       +9     
==========================================
+ Hits       184496   184544      +48     
+ Misses      15943    15915      -28     
+ Partials     7993     7989       -4     
Files with missing lines Coverage Δ
lib/internal/fs/glob.js 91.38% <75.00%> (-0.59%) ⬇️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robinvw1 robinvw1 force-pushed the globstar-hidden-files branch from 7499588 to f0acade Compare December 10, 2025 11:01
Using globstar in glob pattern should not prevent dot (hidden) files
from being matched.
@aduh95 aduh95 force-pushed the globstar-hidden-files branch from f0acade to b0b8df3 Compare December 10, 2025 12:22
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using globstar in glob pattern prevents dot (hidden) files from being matched

4 participants