Skip to content

Conversation

@anishsingh1250
Copy link

Hello, this is my first contribution for the open source community and I'm looking forward for more opportunities.

@netlify
Copy link

netlify bot commented Dec 28, 2024

Deploy Preview for gsoc-organizations ready!

Name Link
🔨 Latest commit 58d0bd2
🔍 Latest deploy log https://app.netlify.com/sites/gsoc-organizations/deploys/677ba3909e819400085d1339
😎 Deploy Preview https://deploy-preview-154--gsoc-organizations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anishsingh1250
Copy link
Author

Inform me if some changes needs to be done

beingnoble03
beingnoble03 previously approved these changes Dec 28, 2024
Copy link
Collaborator

@beingnoble03 beingnoble03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Can you please make this correct?

Co-authored-by: Noble Mittal <[email protected]>
Comment on lines 40 to 41
"title": "Contributing to aossie.org",
"url": "https://github.com/AOSSIE-Org/EduAid"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not pointing this out earlier but I don't think title matches with the url it points to.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay I am doing it.

@anishsingh1250
Copy link
Author

Hello sir, merge my commit.

beingnoble03
beingnoble03 previously approved these changes Jan 3, 2025
Copy link
Collaborator

@beingnoble03 beingnoble03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@beingnoble03
Copy link
Collaborator

@anishsingh1250 looks like the lint check is failing. You'll need to run prettier to fix this. Can you please run that and push the changes?

@anishsingh1250
Copy link
Author

I hope the issue is fixed now, if not please help me to correct it.

@anishsingh1250
Copy link
Author

please review it

@beingnoble03
Copy link
Collaborator

hey @anishsingh1250, it's still failing. also, you pushed .vscode/settings.json (which is not required), can you revert back this change or remove it from the PR? to solve the lint issue: please run npm run lint -- --write

@anishsingh1250
Copy link
Author

yes

@anishsingh1250
Copy link
Author

anishsingh1250 commented Jan 6, 2025

yes

but I think it is still failing after running the npm run lint -- --write . Please guide me
Screenshot 2025-01-06 151030

@anishsingh1250
Copy link
Author

@beingnoble03 please look at this. I've tried all the way possible.

@anishsingh1250
Copy link
Author

sir, please review it.

@nishantwrp
Copy link
Owner

These links seem to be too specific to individual projects by the orgs. imp_links.json should ideally link more broader resources OR documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants