Skip to content

feat(poll): improve poll card and dialog UI #16137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DorraJaouad wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(poll): improve poll card and dialog UI #16137

DorraJaouad wants to merge 1 commit into from

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Oct 12, 2025 •
edited
Loading

☑️ Resolves

  • It may not be obvious for users if the poll is anonymous nor if it is multiple choice (only after trying to select more)
  • It is hard to visually detect if the poll is open.

Improvement for upstream lib regarding NcChip: nextcloud-libraries/nextcloud-vue#7652

  • add variant prop values to showcase success, warningm error state like we have for other components
  • It lacks inline end space

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Not voted 🏡 voted 🏁 closed
image image image
image image

A problem: due to the fact that we don't have a trigger to update poll data (someone voted) when poll is anonymous, moderators are not able to see the number of voters until they reload.

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🍏 Next Major (33) milestone Oct 12, 2025
@DorraJaouad DorraJaouad self-assigned this Oct 12, 2025
@DorraJaouad
Copy link
Contributor Author

DorraJaouad commented Oct 13, 2025 •
edited
Loading

image

Better to use inline NcActions here and I am a bit skeptical about Save as a draft after closing the poll and showing results (it is not clear, what draft refers to, is it poll with results or with poll skeleton)

Antreesy
Antreesy reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we'll be more in line with design changes, if we adapt the deck cards layout (chips below title)?
image

Regarding inline actions: I think only owner + moderators have them, and from all of them only 'Close poll' I would consider moving out. Though it could have been a decision to prevent misclicking

@DorraJaouad
Copy link
Contributor Author

DorraJaouad commented Oct 14, 2025 •
edited
Loading

Maybe we'll be more in line with design changes, if we adapt the deck cards layout (chips below title)?

I still rather choose to be different so it is easier to distinguish or to visually remember it ?

@DorraJaouad DorraJaouad mentioned this pull request Oct 14, 2025
Merged
3 tasks
Antreesy
Antreesy reviewed Oct 20, 2025
View reviewed changes
@DorraJaouad DorraJaouad force-pushed the feat/noid/enhance-poll-layout branch from 2f7924b to 966f993 Compare October 21, 2025 08:58
@DorraJaouad DorraJaouad force-pushed the feat/noid/enhance-poll-layout branch from 966f993 to 3aebb75 Compare November 20, 2025 15:05
@DorraJaouad DorraJaouad requested a review from Antreesy November 20, 2025 15:07
Antreesy
Antreesy reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise ok

src/components/PollViewer/PollViewer.vue
|| (this.poll && this.actorStore.checkIfSelfIsActor(this.poll))
},
pollSummaryText() {
Copy link
Contributor

@Antreesy Antreesy Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe don't change these strings? They feel more confusing to me

Copy link
Contributor Author

@DorraJaouad DorraJaouad Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean confusing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy left review comments

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

At least 1 approving review is required to merge this pull request.

Assignees

@DorraJaouad DorraJaouad

Labels

enhancement feature: frontend 🖌️ "Web UI" client feature: polls 📊

Projects

None yet

Milestone

🍏 Next Major (33)

Development

Successfully merging this pull request may close these issues.

3 participants

@DorraJaouad @Antreesy