-
Notifications
You must be signed in to change notification settings - Fork 15
Add support for &- and |-syntax and make OR/AND support work in general #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| ]); | ||
| }); | ||
|
|
||
| test('Symbol table contains anonymous variables', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didnt add a dedicated test for these in the PR adding anon vars, but I figure its nice to have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have an example for anonymous relationship as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your wish is my command
… into supportFullAndOrSBCompletions
…on var without label (should not include)
Before we had support for queries like
MATCH (n) WHERE n:A AND n:B AND n:Cbut only one special case for OR (for testing)Now we support any OR-usage, even nested cases like
MATCH (n) WHERE n:A AND n:B OR n:C AND n:D(where AND is evaluated first, so we get n { OR(AND(A,B), AND(C,D)) } )
Also, we didnt support the &/|-syntax for and/or which can be used in MATCH, or as an alternative in WHERE. Now we do!
ex.
MATCH (n:A&B) WHERE n:C|D-> n { AND(A, B, OR(C,D)) } )Closes LS-5
Closes LS-6
Closes LS-84