fix(iroh): Remove call to noq's handle_network_change#4356
Open
matheus23 wants to merge 2 commits into
Open
Conversation
2 tasks
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4356/docs/iroh/ Last updated: 2026-06-23T15:43:11Z |
Member
Author
|
dogfood session seems to have gone fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes the call to noq's
handle_network_change. The patchbay tests keep working for me when I run them locally.Breaking Changes
None
Notes & open questions
Committing this & creating a PR mostly for discussion.
The network change hint for recoverable or unrecoverable paths did not make sense: Why would you want to clear the local IP of a path's 4-tuple only if you have an interface with the old path's interface? What you actually want to check is whether you can reach the remote address from one of your interfaces, but figuring that out will depend on routing table configurations and is much more complicated. I think the old version would also break paths that required you to specify the correct local IP (link-local IPv6 addresses? even if we don't support them today).
So after seeing this I decided to just remove them outright. And it doesn't seem to affect things?
We could try dogfooding this branch to see if it really doesn't have any effect.
Change checklist