[ISSUE #8700]♻️Add real correctness-first target runners

[mxsm]

Which Issue(s) This PR Fixes(Closes)

• Fixes [Refactor♻️] Add real correctness-first target runners #8700

Brief Description

Add the four repository-owned correctness-first runners required before M10 target-hardware measurements:

• force-kill and recover a real SyncFlush store after durable acknowledgements;
• delete derived state and verify hole-free CommitLog replay;
• verify bounded transport overload preserves control-plane capacity and converges;
• keep Compaction reads fail-closed while derived state is recovering.

Add one explicit target-runner command inventory for all four correctness checks and all eleven measurement variants. Generated sidecar manifests now contain executable repository commands instead of runner placeholders, while target-host metadata remains intentionally unset until an approved collection run.

Update the migration checklists to record runner readiness without claiming that the approved baseline/candidate performance gate or HUMAN sign-off has completed.

How Did You Test This Change?

• python -m py_compile scripts/architecture_target_runner.py scripts/architecture_performance_sidecar.py scripts/tests/test_architecture_target_runner.py scripts/tests/test_architecture_performance_sidecar.py
• python -m unittest scripts.tests.test_architecture_target_runner scripts.tests.test_architecture_performance_sidecar -v
• all four python scripts/architecture_target_runner.py correctness <check-id> invocations
• python scripts/architecture_performance_sidecar.py --generate-manifest target/architecture-refactor/M10/runner-manifest-8700.json
• python scripts/architecture_performance_guard.py --validate-profiles
• cargo clippy -p rocketmq-store --test architecture_correctness -- -D warnings
• cargo fmt --all -- --check
• cargo clippy --workspace --no-deps --all-targets --all-features -- -D warnings
• git diff --check

Summary by CodeRabbit

• New Features

  • Added a unified command runner for standardized architecture correctness and performance checks.
  • Added executable validation for sync-flush recovery and derived-state replay integrity.

• Documentation

  • Updated production-readiness plans and checklists to mark four correctness checks complete.
  • Documented runner commands, validation coverage, and required target-environment metadata.
  • Clarified that performance gates remain open pending approved hardware results.

• Tests

  • Added coverage for command validation, failure handling, manifest generation, and recovery scenarios.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: da6e3dd3-1ac9-40bf-a048-ef312ced2dd0

📥 Commits

Reviewing files that changed from the base of the PR and between e8ba80c and d7c57e7.

📒 Files selected for processing (9)

• docs/plans/architecture-refactor-migration/CHECKLIST.md
• docs/plans/architecture-refactor-migration/REMAINING-TASKS.md
• docs/plans/architecture-refactor-migration/phase-3-production-readiness/10-durability-and-performance.md
• docs/plans/architecture-refactor-migration/phase-3-production-readiness/10-performance-gate-evidence.md
• rocketmq-store/tests/architecture_correctness.rs
• scripts/architecture_performance_sidecar.py
• scripts/architecture_target_runner.py
• scripts/tests/test_architecture_performance_sidecar.py
• scripts/tests/test_architecture_target_runner.py

---

Walkthrough

Adds two RocketMQ store correctness tests, a unified Python runner for four correctness checks and measurement variants, sidecar manifest integration, validation tests, and Issue 8700 readiness documentation.

Changes

Correctness runner delivery

Layer / File(s)	Summary
Store recovery correctness checks rocketmq-store/tests/architecture_correctness.rs	Adds SyncFlush crash-recovery validation and derived-state CommitLog replay checks without offset holes.
Unified target runner scripts/architecture_target_runner.py, scripts/tests/test_architecture_target_runner.py	Defines frozen command inventories, validates selections, executes commands sequentially, propagates failures, and adds coverage for inventory and fail-closed behavior.
Manifest wiring and readiness tracking scripts/architecture_performance_sidecar.py, scripts/tests/test_architecture_performance_sidecar.py, docs/plans/architecture-refactor-migration/...	Replaces manifest placeholders with runner commands, verifies command shape, and records Issue 8700 correctness completion while leaving performance gates open.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related issues

• [Refactor♻️] Add target hardware performance sidecar runner #8682 — Covers the target-hardware sidecar runner implemented and wired by this change.

Possibly related PRs

• mxsm/rocketmq-rust#8683 — Directly updates the sidecar to use the new unified target runner.
• mxsm/rocketmq-rust#8697 — Changes measurement profiles consumed by the unified measurement runner.

Suggested labels: refactor♻️, approved, auto merge, AI review first, enhancement✨, testing🧪, ready to review, waiting-review

Suggested reviewers: rocketmq-rust-bot, spacexcn

Sequence Diagram(s)

sequenceDiagram
  participant Operator
  participant architecture_target_runner
  participant Cargo
  participant RocketMQStore
  Operator->>architecture_target_runner: select correctness check
  architecture_target_runner->>Cargo: execute cargo test
  Cargo->>RocketMQStore: run recovery validation
  RocketMQStore-->>Cargo: return test status
  Cargo-->>architecture_target_runner: return command status
  architecture_target_runner-->>Operator: return final status

Loading

Poem

A rabbit hops where runners gleam,
Four checks awaken from a dream.
Logs replay, acknowledgements stay,
Placeholders quietly flee away.
The hardware gate still waits its turn.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch mxsm/architecture-refactor-correctness-runners

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[rocketmq-rust-bot]

🔊@mxsm 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.