mobkit.timer: Add support for floats #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
out of curiosity: why did it previously just support integers? |
Contributor
Author
|
sorry for the late response the original code rounds down to the nearest second, while you can use float intervals they don't function how you'd expect them to. the updated code instead divides by the interval before rounding down, which should allow floats to function how you'd expect them to. |
Contributor
|
will changing precision like this affect any mods that assume its in seconds? otherwise probably fine |
Contributor
Author
|
It might effect performance by a smidgen, though I doubt by any significant amount. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.