fix execute_queues (issue #13) #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
i wonder if there is a way to do this without cycling over the whole queue - probably not. anyways your nesting is off |
Contributor
Author
|
woops... one sec |
Contributor
Author
|
there we go, should be good |
Contributor
Author
|
also the iterator shouldn't be too horrible on performance since it breaks once it finds the function, and most cases it only iterates once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: execute_queues assumes the behaviour it just ran is the first in the list, this is not necessarily true and a higher priority behaviour could have taken its place.