feat(ads-client): temporarily disable cache invalidation on click and impression #7200
+19
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luc-lisi
approved these changes
Feb 2, 2026
luc-lisi
requested changes
Feb 2, 2026
Contributor
luc-lisi
left a comment
luc-lisi
left a comment
There was a problem hiding this comment.
Oh we need to update tests it looks like
Almaju
force-pushed
the
disable-cache-invalidation
branch
2 times, most recently
from
9a0e9eb to
31a1b3f
Compare
… impression This disables cache invalidation in record_click() and record_impression() methods as requested by the mobile team. The functionality will be re-enabled later behind a Nimbus experiment. - Comment out cache invalidation code in record_click() and record_impression() - Remove unused import of pop_request_hash_from_url from client.rs - Mark pop_request_hash_from_url function with #[allow(dead_code)] - Mark invalidate_cache_by_hash method with #[allow(dead_code)] - Ignore test_record_click_invalidates_cache test until cache invalidation is re-enabled - Add TODO comments to remove allow(dead_code) when feature is restored - Update CHANGELOG.md with entry about this change
Almaju
force-pushed
the
disable-cache-invalidation
branch
from
31a1b3f to
73b3763
Compare
luc-lisi
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables cache invalidation in record_click() and record_impression() methods as requested by the mobile team. The functionality will be re-enabled later behind a Nimbus experiment.
Pull Request checklist
[ci full]to the PR title.