Ensure copier app respects defaults and defined branch upon merge #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cbullinger
commented
Dec 4, 2025
cbullinger
commented
- Fix bug that caused PRs to trigger on non-main branch
- Fix bug that caused copier to not respect defaults set in workflow config
Previously, when a workflow had ANY commit_strategy fields, it would completely ignore all defaults. This meant workflows with partial commit_strategy (e.g., only pr_title and pr_body) wouldn't inherit commit_message or use_pr_template from defaults. Changes: - Modified YAMLConfig.SetDefaults() to merge individual fields - Modified WorkflowConfig.SetDefaults() to merge individual fields - Fields now inherited: Type, CommitMessage, PRTitle, PRBody, UsePRTemplate - AutoMerge intentionally NOT inherited for safety when workflow has its own commit_strategy Tests: - Added comprehensive tests in types/config_test.go - Updated existing test in services/main_config_loader_test.go - All tests pass
…e.branch in workflow
dacharyc
approved these changes
Dec 4, 2025
Collaborator
dacharyc
left a comment
dacharyc
left a comment
There was a problem hiding this comment.
Seems plausible 🤷♀️
Let's give it a try!
Collaborator
There was a problem hiding this comment.
Just checking - did we mean to add a new README in this PR, or was this just Claude being overly helpful again?
examples-copier/configs/copier-config-examples/SOURCE-REPO-README.md
Outdated
Show resolved
Hide resolved
…DME.md Co-authored-by: Dachary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.