Skip to content

feat(server): disable validation#1678

Open
dinwwwh wants to merge 4 commits into
middleapi:mainfrom
dinwwwh:feat/server/disable-validations
Open

feat(server): disable validation#1678
dinwwwh wants to merge 4 commits into
middleapi:mainfrom
dinwwwh:feat/server/disable-validations

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Jul 17, 2026

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
orpc Ready Ready Preview, Comment Jul 17, 2026 4:03am

@pkg-pr-new

pkg-pr-new Bot commented Jul 17, 2026

Copy link
Copy Markdown
More templates

@orpc/arktype

npm i https://pkg.pr.new/@orpc/arktype@1678

@orpc/bun

npm i https://pkg.pr.new/@orpc/bun@1678

@orpc/client

npm i https://pkg.pr.new/@orpc/client@1678

@orpc/cloudflare

npm i https://pkg.pr.new/@orpc/cloudflare@1678

@orpc/contract

npm i https://pkg.pr.new/@orpc/contract@1678

@orpc/experimental-effect

npm i https://pkg.pr.new/@orpc/experimental-effect@1678

@orpc/evlog

npm i https://pkg.pr.new/@orpc/evlog@1678

@orpc/json-schema

npm i https://pkg.pr.new/@orpc/json-schema@1678

@orpc/nest

npm i https://pkg.pr.new/@orpc/nest@1678

@orpc/next

npm i https://pkg.pr.new/@orpc/next@1678

@orpc/openapi

npm i https://pkg.pr.new/@orpc/openapi@1678

@orpc/opentelemetry

npm i https://pkg.pr.new/@orpc/opentelemetry@1678

@orpc/pino

npm i https://pkg.pr.new/@orpc/pino@1678

@orpc/publisher

npm i https://pkg.pr.new/@orpc/publisher@1678

@orpc/ratelimit

npm i https://pkg.pr.new/@orpc/ratelimit@1678

@orpc/server

npm i https://pkg.pr.new/@orpc/server@1678

@orpc/shared

npm i https://pkg.pr.new/@orpc/shared@1678

@orpc/tanstack-query

npm i https://pkg.pr.new/@orpc/tanstack-query@1678

@orpc/valibot

npm i https://pkg.pr.new/@orpc/valibot@1678

@orpc/zod

npm i https://pkg.pr.new/@orpc/zod@1678

commit: b2d04ca

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ One doc detail to clarify.

Reviewed changes — added disableInputValidation/disableOutputValidation runtime toggles to the server builder and implementer, plus docs and tests.

  • Add ProcedureConfig to ProcedureDefinition and BuilderDefinition, with .$config methods on Builder and Implementer.
  • Propagate config through augmentRouter, augmentImplementedRouter, and createRouterImplementer, and skip validation loops in executeProcedureInternal.
  • Rename docs from validation-errors.md to validation-customization.md and update references.

Pullfrog  | Fix all ➔Fix 👍s ➔View workflow run | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏

Comment thread apps/content/docs/advanced/validation-customization.md
@codspeed-hq

codspeed-hq Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 18 untouched benchmarks


Comparing dinwwwh:feat/server/disable-validations (b2d04ca) with main (da7eb75)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (275ccbc) during the generation of this report, so da7eb75 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — the latest commit (b2d04ca) tightens test fixtures and assertions for the new ProcedureConfig propagation.

  • Updated implementer-procedure.test.ts so the ProcedureImplementer fixture explicitly carries disableInputValidation.
  • Updated implementer-router.test.ts so the expected ~orpc snapshots account for the config spread and the omit(options, ...) shape now used by augmentRouter.

Pullfrog  | View workflow run | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant