Skip to content

Copy nested capabilities_ex structure during interface init #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtfriesen merged 5 commits into from
Nov 11, 2025
Merged

Copy nested capabilities_ex structure during interface init #923

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
753345b
copy capabilities_ex during interface init
mtfriesen Nov 11, 2025
645ebb3
add null check
mtfriesen Nov 11, 2025
4c68232
remove null check and fix error handling
mtfriesen Nov 11, 2025
7d973a7
more complete and correct fix
mtfriesen Nov 11, 2025
5b8c077
common cleanup
mtfriesen Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/xdp/bind.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ XdpIfpDereferenceInterface(
if (Interface->WorkQueue != NULL) {
XdpShutdownWorkQueue(Interface->WorkQueue, FALSE);
}
ExFreePoolWithTag((VOID *)Interface->Capabilities.CapabilitiesEx, XDP_POOLTAG_IF);
ExFreePoolWithTag(Interface, XDP_POOLTAG_IF);
}
}
Expand Down Expand Up @@ -1349,6 +1350,7 @@ XdpIfAddInterfaces(
for (UINT32 Index = 0; Index < InterfaceCount; Index++) {
XDP_ADD_INTERFACE *AddIf = &Interfaces[Index];
XDP_INTERFACE *Interface = NULL;
XDP_CAPABILITIES_INTERNAL *MutableCapabilities;

if (!XdpValidateCapabilitiesEx(
AddIf->InterfaceCapabilities->CapabilitiesEx,
Expand All @@ -1372,15 +1374,34 @@ XdpIfAddInterfaces(
Interface->XdpIfApi.RemoveInterfaceComplete = AddIf->RemoveInterfaceComplete;
Interface->XdpIfApi.InterfaceContext = AddIf->InterfaceContext;
Interface->XdpDriverApi.OpenConfig.Dispatch = &XdpOpenDispatch;
InitializeListHead(&Interface->Clients);

//
// Temporarily alias the const interface capabilities field to allow
// copying and fixing up pointers during initialization.
//
MutableCapabilities = (XDP_CAPABILITIES_INTERNAL *)&Interface->Capabilities;
RtlCopyMemory(
(XDP_CAPABILITIES_INTERNAL *)&Interface->Capabilities,
MutableCapabilities,
AddIf->InterfaceCapabilities,
sizeof(Interface->Capabilities));
InitializeListHead(&Interface->Clients);
MutableCapabilities->CapabilitiesEx =
ExAllocatePoolZero(
NonPagedPoolNx, AddIf->InterfaceCapabilities->CapabilitiesEx->Header.Size,
XDP_POOLTAG_IF);
if (MutableCapabilities->CapabilitiesEx == NULL) {
Status = STATUS_NO_MEMORY;
goto Exit;
}
RtlCopyMemory(
(VOID *)MutableCapabilities->CapabilitiesEx,
AddIf->InterfaceCapabilities->CapabilitiesEx,
AddIf->InterfaceCapabilities->CapabilitiesEx->Header.Size);

Interface->WorkQueue =
XdpCreateWorkQueue(XdpIfpInterfaceWorker, DISPATCH_LEVEL, XdpDriverObject, NULL);
if (Interface->WorkQueue == NULL) {
ExFreePoolWithTag((VOID *)Interface->Capabilities.CapabilitiesEx, XDP_POOLTAG_IF);
ExFreePoolWithTag(Interface, XDP_POOLTAG_IF);
Status = STATUS_NO_MEMORY;
goto Exit;
Expand Down
Loading