Fix generator crash composing plugin under long paths with scoped package names#11218
Merged
Merged
Conversation
…kage names Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix generator crashing issue when composing plugin under long path
Fix generator crash composing plugin under long paths with scoped package names
Jul 8, 2026
commit: |
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
jsquire
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C# generator crashed when composing a plugin whose
node_modulespackage directory resolved to a long path. Scoped package names like@azure-typespec/http-client-csharp-mgmtretained their forward slash on Windows, producing a mixed-separator path (...\node_modules\@azure-typespec/http-client-csharp-mgmt). Once long enough to trigger the runtime's\\?\extended-length prefix — which requires canonical backslash separators —Directory.EnumerateFilesfailed with "The filename, directory name, or volume label syntax is incorrect."Changes
GeneratorHandler.AddPluginDlls: replacedPath.Combine(rootDirectory, NodeModulesDir, package)with a newGetPackageDirectoryhelper that splits scoped package names on/into separate path segments, normalizing separators to the platform separator.