Remove redundant top-level describe wrappers from @typespec/compiler tests#11208
Open
timotheeguerin wants to merge 4 commits into
Open
Remove redundant top-level describe wrappers from @typespec/compiler tests#11208timotheeguerin wants to merge 4 commits into
timotheeguerin wants to merge 4 commits into
Conversation
commit: |
Contributor
|
No changes needing a change description found. |
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11205, applying the same cleanup to the
@typespec/compilerpackage.Per
CONTRIBUTING.md, a singledescribe(...)wrapping an entire test file is redundant (the file name already provides context). This PR removes those top-level wrappers and dedents the contents, usingit()directly at the top level. Nested/sub-groupdescribe()calls are left intact.Scope
describe, no top-levelit/test).describes.templates/files (tsp init scaffolding, not compiler tests).Notes
Validation
prettierandoxlintclean.