fix(openapi3): avoid duplicating parameter @extension on schema#11204
Open
timotheeguerin wants to merge 1 commit into
Open
fix(openapi3): avoid duplicating parameter @extension on schema#11204timotheeguerin wants to merge 1 commit into
@extension on schema#11204timotheeguerin wants to merge 1 commit into
Conversation
Parameter-level @extension values were emitted both on the OpenAPI Parameter Object and its nested schema. They are now emitted only on the parameter object. Fixes #8271
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8271
Problem
An
@extensionapplied to a query/path/header parameter property was emitted twice: once on the OpenAPI Parameter Object root (correct) and once inside the nestedschemaobject (unwanted duplicate).{ "name": "filter", "in": "query", "required": true, "schema": { "type": "string", "x-my-ext": "hello" }, "x-my-ext": "hello" }Fix
In
getOpenAPIParameterBase, the parameter property's own extension keys are stripped from the parameterschema(they remain on the Parameter Object root, consistent with the existingparameter componenttest and OpenAPI conventions).Tests
Added a test asserting the extension is present on the parameter object and absent from its
schemafor both query and path parameters.