Accessibility and UIA Support for XAML Fabric implementation #15466
Conversation
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
protikbiswas100
changed the title
iamAbhi-916
left a comment
iamAbhi-916
left a comment
There was a problem hiding this comment.
lgtm
but one thing we are not traversing into children, thats intentional? ContentIslandComponentView this will be the boundary
vnext/Microsoft.ReactNative/Fabric/Composition/ContentIslandComponentView.cpp
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/ContentIslandComponentView.cpp
Show resolved
Hide resolved
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Yes, this is intentional and correct. Here's why:
|
sundaramramaswamy
left a comment
sundaramramaswamy
left a comment
There was a problem hiding this comment.
Approved with comments.
| // Check if the point is within the bounds of this ContentIslandComponentView. | ||
| // This ensures that hit tests correctly return this view's tag for UIA purposes, | ||
| // even when the actual content (XAML buttons, etc.) is hosted in the ContentIsland. | ||
| auto props = viewProps(); |
There was a problem hiding this comment.
Prefer const auto props = viewProps().
When declaring a variable in C++, almost always default to const T var = value. Drop const only if you know you're going to write to it. Why? Refer What is “const correctness”?.
| props->pointerEvents == facebook::react::PointerEventsMode::BoxOnly) && | ||
| ptLocal.x >= 0 && ptLocal.x <= m_layoutMetrics.frame.size.width && ptLocal.y >= 0 && | ||
| ptLocal.y <= m_layoutMetrics.frame.size.height) { | ||
| localPt = ptLocal; |
There was a problem hiding this comment.
Similarly named variables should usually be avoided. They are hard to understand for readers. Consider renaming ptLocal to something else.
4 participants
Description
Accessibility and UIA Support for XAML Fabric implementation
Type of Change
Why
To ensure Accessibility props are read in Accessibility Insights.
Resolves #15325
What
Override hitTest in ContentIslandComponentView to properly handle hit testing for content inside the ChildSiteLink/ContentIsland. The method is checking if the point is within the ContentIslandComponentView's bounds
If yes, return the tag of the ContentIslandComponentView itself (or the tag that represents it properly)
This allows the accessibility tree to properly identify the container of the XAML content
Screenshots & Testing
xaml.mp4
Changelog
Should this change be included in the release notes: yes
Add a brief summary of the change to use in the release notes for the next release.
Accessibility and UIA Support for XAML Fabric implementation
Microsoft Reviewers: Open in CodeFlow