fix(ipynb): catch decoding exceptions in accepts() to prevent pipeline crashes on non-decodable application/json files#2185
Open
aoright wants to merge 1 commit into
Open
Conversation
…e crashes on non-decodable application/json files Signed-off-by: 辰言 <oncwnuIWp30GguOyJ615Fqj8H-yc@git.weixin.qq.com>
|
@aoright please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1894.
When converting files whose MIME type starts with
application/jsonbut contain non-ASCII/binary data (such as a French PDF containing UTF-8 characters that failed to decode using the system's default locale/ASCII codec, or other binary files),IpynbConverter.accepts()raises aUnicodeDecodeErrororValueErrorwhich propagates uncaught and crashes the entire conversion pipeline.This PR wraps the
decode()operation inIpynbConverter.accepts()inside atry/except (UnicodeDecodeError, ValueError, LookupError)block, returningFalsegracefully when the file is not decodable, instead of raising an exception.Verification
test_ipynb_converter_accepts_handling_decode_errortopackages/markitdown/tests/test_module_misc.py.