Conversation
* Various updates - use consistent app name so all downloaded models go to the same location - add some utilities - ensure EPs are downloaded to make it clear that that is what takes time on the first run - add more space in the code to separate sections - reorder some things to try and make the output a bit more intuitive if you haven't read the code yet - target net9* everywhere - the SDK targets net8 as a lower common denominator. app can target anything later than that - try and clarify the model/model variant options in HelloFoundryLocalSdk - keep other apps simple and alias based * Update comments * Update samples/cs/GettingStarted/src/FoundryLocalWebServer/Program.cs Co-authored-by: Copilot <[email protected]> * Fix LoggerFactory lifetime --------- Co-authored-by: Copilot <[email protected]>
…ndry-Local into samuel100/sdkvnext
…o samuel100/sdkvnext
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes build issues for Linux x64 by ensuring native ONNX Runtime libraries are properly copied during the build process and by making the ExcludeExtraLibs.props import unconditional across all sample projects.
Key Changes:
- Removed conditional imports (
Condition="'$(PublishDir)' != ''") from all sample project files to ensure ExcludeExtraLibs.props is always imported - Added Linux x64-specific build targets to manually copy ONNX Runtime GPU and GenAI CUDA native libraries
- Added centralized package version for Microsoft.ML.OnnxRuntimeGenAI.Cuda
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/cs/GettingStarted/windows/ModelManagementExample/ModelManagementExample.csproj | Removed PublishDir condition from ExcludeExtraLibs.props import |
| samples/cs/GettingStarted/windows/HelloFoundryLocalSdk/HelloFoundryLocalSdk.csproj | Removed PublishDir condition from ExcludeExtraLibs.props import |
| samples/cs/GettingStarted/windows/FoundryLocalWebServer/FoundryLocalWebServer.csproj | Removed PublishDir condition from ExcludeExtraLibs.props import |
| samples/cs/GettingStarted/windows/AudioTranscriptionExample/AudioTranscriptionExample.csproj | Removed PublishDir condition from ExcludeExtraLibs.props import |
| samples/cs/GettingStarted/cross-platform/ModelManagementExample/ModelManagementExample.csproj | Removed PublishDir condition from ExcludeExtraLibs.props import |
| samples/cs/GettingStarted/cross-platform/HelloFoundryLocalSdk/HelloFoundryLocalSdk.csproj | Removed PublishDir condition from ExcludeExtraLibs.props import and extra blank line |
| samples/cs/GettingStarted/cross-platform/FoundryLocalWebServer/FoundryLocalWebServer.csproj | Removed PublishDir condition from ExcludeExtraLibs.props import |
| samples/cs/GettingStarted/cross-platform/AudioTranscriptionExample/AudioTranscriptionExample.csproj | Removed PublishDir condition from ExcludeExtraLibs.props import |
| samples/cs/GettingStarted/ExcludeExtraLibs.props | Added Linux x64 build support with manual native library copy targets |
| samples/cs/GettingStarted/Directory.Packages.props | Added Microsoft.ML.OnnxRuntimeGenAI.Cuda package version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samples/cs/GettingStarted/windows/HelloFoundryLocalSdk/HelloFoundryLocalSdk.csproj
Outdated
Show resolved
Hide resolved
…undryLocalSdk.csproj Co-authored-by: Copilot <[email protected]>
samuel100
reviewed
Nov 17, 2025
Contributor
samuel100
left a comment
samuel100
left a comment
There was a problem hiding this comment.
I've added the props changes into my branch, but left the csproj files the same (with publish)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.