mod refmvs: backport shrinkage of RefMvsFrame from dav1d 1.5.2#1462
Open
fbossen wants to merge 2 commits intomemorysafety:mainfrom
Open
mod refmvs: backport shrinkage of RefMvsFrame from dav1d 1.5.2#1462fbossen wants to merge 2 commits intomemorysafety:mainfrom
mod refmvs: backport shrinkage of RefMvsFrame from dav1d 1.5.2#1462fbossen wants to merge 2 commits intomemorysafety:mainfrom
Conversation
Includes updates to load_tmvs() asm implementations.
kkysen
reviewed
Dec 29, 2025
| let diff2 = get_poc_diff(seq_hdr.order_hint_n_bits, rpoc as i32, rrpoc as i32); | ||
| // unsigned comparison also catches the < 0 case | ||
| rf.mfmv_ref2ref[n][m] = if diff2 as u32 > 31 { 0 } else { diff2 }; | ||
| rf.mfmv_ref2ref[n][m] = if diff2 as u32 > 31 { 0 } else { diff2 as u8 }; |
Collaborator
There was a problem hiding this comment.
Is the diff as u32 > 31 still correct (or idiomatic) with the new smaller types?
Contributor
Author
There was a problem hiding this comment.
This comparison shouldn't be impacted by the smaller types. diff2 can still be as wide as before AFAICT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.