Skip to content

Conversation

@brysonbw
Copy link
Contributor

@brysonbw brysonbw commented Oct 9, 2025

Description

Changes

  • Redesign report button

Additional details

Before

report-hint-banner-before.mov

Dismiss when clearing playground

report-hint-banner-dismiss-on-clear-before.mov

After

report-hint-banner-after.mov

Related issues and pull requests

@brysonbw brysonbw requested a review from a team as a code owner October 9, 2025 05:14
@brysonbw brysonbw force-pushed the allow-report-hint-banner-to-be-dismissed branch from 2d3cf8e to f52688e Compare October 9, 2025 06:07
@caugner
Copy link
Contributor

caugner commented Oct 9, 2025

@brysonbw Note that in conventional commits there is no space between the change type and the scope, see this example.

@brysonbw brysonbw force-pushed the allow-report-hint-banner-to-be-dismissed branch from f52688e to 7139f2c Compare October 9, 2025 11:50
@brysonbw brysonbw changed the title fix (playground): allow report hint banner to be dismissed fix(playground): allow report hint banner to be dismissed Oct 9, 2025
@brysonbw brysonbw force-pushed the allow-report-hint-banner-to-be-dismissed branch from 2ebbd7b to 686ee57 Compare October 18, 2025 02:22
@brysonbw brysonbw requested a review from a team as a code owner October 18, 2025 02:23
@brysonbw brysonbw requested a review from caugner October 18, 2025 02:23
@brysonbw brysonbw changed the title fix(playground): allow report hint banner to be dismissed fix(playground): report hint banner updates Oct 18, 2025
@brysonbw brysonbw force-pushed the allow-report-hint-banner-to-be-dismissed branch from 686ee57 to d09ea91 Compare October 24, 2025 15:18
@caugner caugner changed the title fix(playground): report hint banner updates fix(playground): redesign report button Nov 4, 2025
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reduce this PR to updating the design of the banner, i.e. removing the dismiss part.

@brysonbw brysonbw requested a review from caugner November 6, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants