-
Notifications
You must be signed in to change notification settings - Fork 23
fix(playground): redesign report button #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brysonbw
wants to merge
6
commits into
mdn:main
Choose a base branch
from
brysonbw:allow-report-hint-banner-to-be-dismissed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(playground): redesign report button #892
brysonbw
wants to merge
6
commits into
mdn:main
from
brysonbw:allow-report-hint-banner-to-be-dismissed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d3cf8e to
f52688e
Compare
Contributor
|
@brysonbw Note that in conventional commits there is no space between the change type and the scope, see this example. |
f52688e to
7139f2c
Compare
2ebbd7b to
686ee57
Compare
686ee57 to
d09ea91
Compare
caugner
requested changes
Nov 4, 2025
Contributor
caugner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's reduce this PR to updating the design of the banner, i.e. removing the dismiss part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Additional details
Before
report-hint-banner-before.mov
report-hint-banner-dismiss-on-clear-before.mov
After
report-hint-banner-after.mov
Related issues and pull requests
Seeing something inappropriate?hint doesn't have dismiss/close button #710Seeing something inappropriate?hint doesn't go away after reporting #711