-
Notifications
You must be signed in to change notification settings - Fork 165
GH-367 Render tooltip for Enterprise installations #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
GH-367 Render tooltip for Enterprise installations #949
Conversation
This adds support for rendering tooltips for links from Enterprise GitHub installations by checking the configured Enterprise Base URL. It also adds unit tests to verify the URL parsing logic for both SaaS and Enterprise links.
|
Hello @akshat-khosya, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
avasconcelos114
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! 🎊
I left a couple of comments with regards to one of the links in the tooltip as well as testing related to it. Let me know if you have any questions about them!
…urladded db schema creation in start command and Add comprehensive unit tests for Enterprise and Cloud scenarios
c8c4dd4 to
0d5cca4
Compare
avasconcelos114
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! things are looking good to me
Summary
This adds support for rendering tooltips for links from Enterprise GitHub installations by checking the configured Enterprise Base URL. It also adds unit tests to verify the URL parsing logic for both SaaS and Enterprise links.
Ticket Link
#367