[without-ssl-conf.d] Add default.conf without ssl termination option#115
Open
a-schaefers wants to merge 3 commits intomattermost:mainfrom
Open
[without-ssl-conf.d] Add default.conf without ssl termination option#115a-schaefers wants to merge 3 commits intomattermost:mainfrom
a-schaefers wants to merge 3 commits intomattermost:mainfrom
Conversation
hanzei
requested changes
Dec 17, 2024
Contributor
hanzei
left a comment
hanzei
left a comment
There was a problem hiding this comment.
Thanks for the PR 👍
Can you also please update the README to advertise this new configuration option?
hanzei
added
Awaiting Submitter Action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hello, for users who already have SSL termination via some load balancer within a secured VPC, it might be helpful to provide an nginx configuration option for them.
This can be [optionally, not used by default] used by those who desire it, by changing in
.envthe following varNGINX_CONFIG_PATH=Original,
NGINX_CONFIG_PATH=./nginx/conf.dModified, for those who do not want backend SSL,
NGINX_CONFIG_PATH=./nginx/without-ssl-conf.d