fix: Stop toJSON from firing onDidMaximizedNodeChange #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobysmith568
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 45e16b5:
|
tobysmith568
changed the title
tobysmith568
commented
Jan 20, 2026
| expect(value).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('should stop emitting after dispose', () => { |
Author
There was a problem hiding this comment.
This test was a dupe of the one above it
tobysmith568
commented
Jan 20, 2026
| }); | ||
|
|
||
| it('should not replay last value in replay mode', () => { | ||
| it('should not replay last value when not in replay mode', () => { |
Author
There was a problem hiding this comment.
Pretty sure this test was titled incorrectly?
tobysmith568
force-pushed
the
ts/tojson-inside-onchange
branch
from
47bd351 to
45e16b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1074
Hey - I wasn't able to set the repo up properly on my machine (some issue with Yarn not installing deps?) so I wasn't able to run the unit tests locally - hopefully all is good?