Skip to content

expectation of product #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
affeldt-aist wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

expectation of product #1391

affeldt-aist wants to merge 7 commits into from

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Nov 13, 2024 •
edited
Loading

Motivation for this change
Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Nov 13, 2024
@affeldt-aist affeldt-aist added this to the 1.7.0 milestone Nov 13, 2024
@affeldt-aist
Copy link
Member Author

affeldt-aist commented Nov 15, 2024

Maybe it is better to rename expectation_prod to expectation_mul since the original intent was expectationM.

@affeldt-aist affeldt-aist modified the milestones: 1.7.0, 1.8.0 Nov 22, 2024
@affeldt-aist affeldt-aist marked this pull request as draft December 3, 2024 05:42
@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch 2 times, most recently from 0895272 to bc59196 Compare December 3, 2024 06:03
@affeldt-aist affeldt-aist mentioned this pull request Dec 3, 2024
Merged
2 tasks
@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch 2 times, most recently from 538b914 to d32696d Compare December 3, 2024 07:12
t6s
t6s reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@t6s t6s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed lines 0 -- 878 and quickly looked through 879-.
The latter things need some cleaning.

@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch 5 times, most recently from 0ab14bf to a1eb371 Compare December 4, 2024 09:09
@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch 2 times, most recently from aabd8b3 to a811b46 Compare December 18, 2024 22:43
@affeldt-aist affeldt-aist modified the milestones: 1.8.0, 1.9.0 Dec 18, 2024
@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch 4 times, most recently from a93338c to 1c8f2b0 Compare January 10, 2025 15:54
@affeldt-aist affeldt-aist modified the milestones: 1.9.0, 1.10.0 Feb 5, 2025
@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch 2 times, most recently from 6b84aa9 to b548f8a Compare March 14, 2025 18:21
@affeldt-aist affeldt-aist modified the milestones: 1.10.0, 1.11.0 Mar 30, 2025
@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch 2 times, most recently from b7d4b85 to 43135d6 Compare April 30, 2025 06:54
@affeldt-aist affeldt-aist modified the milestones: 1.11.0, 1.12.0 May 1, 2025
@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch from 43135d6 to 9bcc38f Compare May 12, 2025 06:37
@affeldt-aist affeldt-aist modified the milestones: 1.12.0, 1.13.0 Jun 26, 2025
@affeldt-aist affeldt-aist modified the milestones: 1.13.0, 1.14.0 Aug 13, 2025
@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch 2 times, most recently from 5fe1e86 to ee254fb Compare October 30, 2025 19:46
@affeldt-aist affeldt-aist modified the milestones: 1.14.0, 1.15.0 Oct 30, 2025
@affeldt-aist affeldt-aist mentioned this pull request Dec 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@proux01 proux01 Awaiting requested review from proux01

@hoheinzollern hoheinzollern Awaiting requested review from hoheinzollern

1 more reviewer

@t6s t6s t6s left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

2 participants

@affeldt-aist @t6s