MLE-26427 Initial exclusion support for JSON #1874
Open
+161
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
This PR introduces initial support for excluding specific JSON properties from hash calculations in the incremental write filter. The feature allows users to specify JSON Pointer expressions (RFC 6901) to exclude fields like timestamps or metadata from change detection, preventing unnecessary document rewrites when only these excluded fields change.
Key changes:
- Added
jsonExclusionsparameter throughout theIncrementalWriteFilterclass hierarchy to support exclusion configuration - Implemented
ContentExclusionUtilclass to handle JSON Pointer-based exclusions using Jackson's API - Added comprehensive test coverage demonstrating exclusion behavior with multiple write scenarios
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| IncrementalWriteTest.java | Adds test case validating JSON exclusion behavior across three scenarios: initial write, excluded field changes, and non-excluded content changes |
| IncrementalWriteFilter.java | Adds jsonExclusions builder method and integrates exclusion logic into content serialization |
| IncrementalWriteOpticFilter.java | Updates constructor to accept and forward jsonExclusions parameter |
| IncrementalWriteEvalFilter.java | Updates constructor to accept and forward jsonExclusions parameter |
| ContentExclusionUtil.java | New utility class implementing JSON Pointer-based node removal with parent navigation and logging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BillFarber
previously approved these changes
Jan 2, 2026
This isn't quite done - I want to do a PR for excluding XML next, and then refactor the code, likely moving the tests into a new test class. But this pushes things forward a bit with exclusions.
rjrudin
force-pushed
the
feature/26427-exclusions
branch
from
6b56916 to
6c5b7ec
Compare
BillFarber
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't quite done - I want to do a PR for excluding XML next, and then refactor the code, likely moving the tests into a new test class. But this pushes things forward a bit with exclusions.