Skip to content

Conversation

@teodutu
Copy link
Member

@teodutu teodutu commented Jun 25, 2021

Decrease the time complexity of the build_operation_nodes function by using a dictionary to reduce its complexity from O(len(operation_nodes)^2) to O(len(operation_nodes)).

@razvand razvand self-assigned this Mar 23, 2022
@razvand razvand requested a review from radudum10 March 23, 2022 07:09
@razvand razvand requested review from razvand and removed request for radudum10 April 14, 2025 15:22
@razvand razvand removed their assignment Apr 14, 2025
@CristiMacovei CristiMacovei force-pushed the optimise-build_operation_nodes branch from a0cf0b6 to 4741c74 Compare April 25, 2025 14:56
@razvand
Copy link
Member

razvand commented May 2, 2025

@CristiMacovei , not sure what you did but the commit you added seems like a merge commit. And it's not properly authored:

commit 4741c74acd02dadd2eb2dc805992e90197e50f34 (HEAD -> optimise-build_operation_nodes, teodutu/optimise-build_operation_nodes)
Merge: 8288b49 d417bf9
Author: CristiMacovei <[email protected]>
Date:   Fri Apr 25 08:48:05 2025 +0300

    Improve `build_operation_nodes` complexity

The goal is to have a single commit as part of the PR, that includes @teodutu 's work together with an update to make it work with the current version of Sandblaster. That commit will be co-authored by you and @teodutu .

For that do the following steps:

  1. Create a temporary branch from the teodutu remote:

    git remote add teodutu https://github.com/teodutu/sandblaster
    git fetch teodutu
    git branch tmp teodutu/optimise-build_operation_nodes
  2. Create a branch named /optimise-build_operation_nodes from the master branch. We will use it to build the new commit:

    git checkout master
    git checkout -b optimise-build_operation_nodes
  3. Cherry-pick @teodutu 's commit:

    git cherry-pick 8288b493336a
  4. Make updates to the commit as required, maybe there are conflicts, maybe there are things not working.

  5. Add a Signed-off-by: Teodor Dutu <email...> and then a Signed-off-by: Cristian Macovei <email...> message to the commit message.

  6. Force push the branch to @teodutu 's remote:

    git push --force teodutu optimise-build_operation_nodes:optimise-build_operation_nodes

Decrease the time complexity of the `build_operation_nodes` function by using a dictionary to reduce its complexity from `O(len(operation_nodes)^2)` to `O(len(operation_nodes))`.
@CristiMacovei CristiMacovei force-pushed the optimise-build_operation_nodes branch from 4741c74 to f2d36a0 Compare May 6, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants