-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(icons): add lens-concave and lens-convex
#3831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(icons): add lens-concave and lens-convex
#3831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 ChatGPT Tags suggestions ✨
I've asked ChatGPT for some suggestions for tags.
| "jamiemlaw", | ||
| "karsa-mistmere" | ||
| ], | ||
| "tags": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for the lens-concave icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:
| "tags": [ | |
| "tags": [ | |
| "magnify", | |
| "glass", | |
| "tool", | |
| "visual", |
| "jamiemlaw", | ||
| "karsa-mistmere" | ||
| ], | ||
| "tags": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for the lens-convex icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:
| "tags": [ | |
| "tags": [ | |
| "magnify", | |
| "vision", | |
| "clarity", |
Added or changed iconsIcons as codeWorks for: const LensConcaveIcon = createLucideIcon('LensConcave', [
["path",{"d":"M7 2a1 1 0 0 0-.8 1.6 14 14 0 0 1 0 16.8A1 1 0 0 0 7 22h10a1 1 0 0 0 .8-1.6 14 14 0 0 1 0-16.8A1 1 0 0 0 17 2z"}]
])
const LensConvexIcon = createLucideIcon('LensConvex', [
["path",{"d":"M13.433 2a1 1 0 0 1 .824.448 18 18 0 0 1 0 19.104 1 1 0 0 1-.824.448h-2.866a1 1 0 0 1-.824-.448 18 18 0 0 1 0-19.104A1 1 0 0 1 10.567 2z"}]
]) |
lens-concave and lens-convex
icons/lens-concave.svg
Outdated
| stroke-linejoin="round" | ||
| > | ||
| <path | ||
| d="M7 2a1 1 0 0 0-.806 1.591A14 14 0 0 1 9.012 12a13.9 13.9 0 0 1-2.807 8.393A1 1 0 0 0 7 22h10a1 1 0 0 0 .802-1.597 13.9 13.9 0 0 1-.011-16.79A1 1 0 0 0 17 2z" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's the option to make some of those path segments more mathematically precise, e.g. making the 13.9px radii of some of the arcs 14px instead.
M7 2a1 1 0 0 0-.8 1.6 14 14 0 0 1 0 16.8A1 1 0 0 0 7 22h10a1 1 0 0 0 .8-1.6 14 14 0 0 1 0-16.8A1 1 0 0 0 17 2z
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great optimization and it's done.👍
Description
This PR adds two new icons:
lens-concaveandlens-convex.These icons represent the two fundamental types of lenses used in science, education, physics tools, and optical UI representations.
Icon use case
lens-concave
lens-convex
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/lens-concave.jsonandicons/lens-convex.json.Design
Before Submitting