Skip to content

Conversation

@nathan-de-pachtere
Copy link
Contributor

What is the purpose of this pull request?

  • New Icon

Description

Added new last-commit icon.

Icon use case

To represent the last commit of a branch — or, in the metallurgy industry, we use 'commit' icons to indicate measurements taken on a bar. For example, the 'git-commit-horizontal' icon represents a measurement taken in the middle of a bar, while the 'last-commit' icon would represent a measurement taken at the end of the bar. Nothing to do with commit, but the icon works perfectly.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @colebemis
  • I've based them on the following Lucide icons: git-commit-horizontal
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Oct 29, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT Tags suggestions ✨

I've asked ChatGPT for some suggestions for tags.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Added or changed icons

line-dot-right-horizontal

Preview cohesion message-square
line-dot-right-horizontal
wheat
Preview stroke widths line-dot-right-horizontal
line-dot-right-horizontal
line-dot-right-horizontal
DPI Preview

16px (shadcn/ui)

line-dot-right-horizontal

24px (default)

line-dot-right-horizontal

32px (shadcn/ui + retina)

line-dot-right-horizontal

48px (default + retina)

line-dot-right-horizontal
Icon X-rays line-dot-right-horizontal
Icon Diffs line-dot-right-horizontal
Icon Symmetry

Flip Horizontal

line-dot-right-horizontal

Flip Vertical

line-dot-right-horizontal

Flip Diagonal

line-dot-right-horizontal

Rotate 180°

line-dot-right-horizontal
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const LineDotRightHorizontalIcon = createLucideIcon('LineDotRightHorizontal', [
  ["path",{"d":"M 3 12 L 15 12"}],
  ["circle",{"cx":"18","cy":"12","r":"3"}]
])

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @nathan-de-pachtere

We should name this last-commit-horizontal, since we also have the other commit icons. Can you also create the last-commit-vertical.

Image

@jguddas
Copy link
Member

jguddas commented Nov 17, 2025

It's kinda named after the use case rather than what it depicts, not sure what else we should name it.

@nathan-de-pachtere
Copy link
Contributor Author

nathan-de-pachtere commented Nov 17, 2025

@ericfennis Just checking again… do we really need a horizontal/vertical distinction if the element can be rotated ? What about the reverse / first-commit ?

o- -> first-horizontal
i -> last-vertical
! -> first-vertical
-o -> last-horizontal

@nathan-de-pachtere
Copy link
Contributor Author

It's kinda named after the use case rather than what it depicts, not sure what else we should name it.

@jguddas From my point of view, since I grew up with Pokémon, I’d vote for zarbi!. But Nintendo probably wouldn’t like that, so maybe something like schuppashwusp instead. Or line-with-circle-at-the-end-or-the-beginning-depending-on-the-rotation 😁​

@jguddas
Copy link
Member

jguddas commented Nov 18, 2025

line-dot-right could work.

@nathan-de-pachtere
Copy link
Contributor Author

@jguddas @ericfennis What are we doing / deciding here?

1- What's the chosen name ?
2- Should I do 4 variants ? line-dot-end-horizontal and line-dot-end-vertical and line-dot-start-horizontal and line-dot-start-vertical
3- Should I do 2 variants ? line-dot-end-horizontal and line-dot-end-vertical

@ericfennis
Copy link
Member

I would say number 2

@nathan-de-pachtere
Copy link
Contributor Author

nathan-de-pachtere commented Nov 24, 2025

I would say number 2

@jguddas & @ericfennis are we validating the number 2 ? Or do you prefer right / left / top / bottom ? As for some people on this planet, end will not be the end if they read from right to left...

something like :
line-dot-right-horizontal and line-dot-top-vertical and line-dot-left-horizontal and line-dot-bottom-vertical

@ericfennis
Copy link
Member

@nathan-de-pachtere Reading direction doesn't matter. Left is still left and right is still right.

@nathan-de-pachtere
Copy link
Contributor Author

nathan-de-pachtere commented Dec 5, 2025

@nathan-de-pachtere Reading direction doesn't matter. Left is still left and right is still right.

@ericfennis Name changed and new PRs opened for variants

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 icon About new icons 🫧 metadata Improved metadata

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants