added multi-line for macros#456
Open
jcarletto27 wants to merge 1 commit into
Open
Conversation
Owner
|
Thank you, I understand the idea but the implementation is not ideal currently : 1 - macros cover several type, gcode but also filename and 8 lines for a file name is not really needed ,and confusing, it should be limited to gcode type only not all macros types. if the point 2 can be anyway acceptable because it user responsability to fill the content - I consider the point 1 need to be fixed for merging for proper user experience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add multi-line G-code support for macros
This change allows G-code entered in the Macros module to span multiple lines, making longer macros easier to read and maintain.
Changes
CMDmacro execution to process each non-empty line as an individual command.This makes it possible to write macros such as:
or