try setting x-google-start-bitrate for vp9 #820
+71
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Maybe we should add a simple unit test for |
davidzhao
reviewed
Dec 23, 2025
| pub type OnOfferCreated = Box<dyn FnMut(SessionDescription) + Send + Sync>; | ||
|
|
||
| #[cfg(any(target_os = "windows", target_os = "macos", target_os = "linux"))] | ||
| const DEFAULT_VP9_START_BITRATE_KBPS: u32 = 2500; |
Member
There was a problem hiding this comment.
I think we should use the currently negotiated bitrate? instead of a fixed amount? the JS logic uses 80% of ultimate bitrate. I think it's ok to go to 100% as well
Contributor
Author
There was a problem hiding this comment.
I will address the comment
| Ok(answer) | ||
| } | ||
|
|
||
| fn munge_x_google_start_bitrate(sdp: &str, start_bitrate_kbps: u32) -> String { |
Member
There was a problem hiding this comment.
should we use a proper sdp parser/rewriter? instead of string changes? https://crates.io/crates/sdp
in case we'd need to do more munging for other things
| let mut offer = self.peer_connection.create_offer(options).await?; | ||
| let start_bitrate_kbps = DEFAULT_VP9_START_BITRATE_KBPS; | ||
| let sdp = offer.to_string(); | ||
| // TODO, we should extend the codec support to AV1 ? |
Member
There was a problem hiding this comment.
worth testing if AV1 has this issue or not.. the JS logic is applying to AV1 as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And we should do it for Desktop only