client: Accept MIME parameters in content types#517
Merged
bilelmoussaoui merged 1 commit intoJul 13, 2026
Merged
Conversation
Contributor
Author
|
Tested on my own NixOS flake deployed with Cosmic DE |
caniko
marked this pull request as ready for review
July 13, 2026 15:26
bilelmoussaoui
merged commit Jul 13, 2026
e30741e
into
linux-credentials:main
16 of 17 checks passed
Collaborator
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContentTypecurrently accepts only the two bare media types. That rejects valid Secret Service values with MIME parameters: the specification itself usestext/plain; charset=utf8, and go-keyring sends that exact value.This keeps the existing Text/Blob model, but compares only the base media type. Matching is trimmed and case-insensitive, outgoing serialization stays unchanged, and unknown base types still report the original full value.
I hit this through kubelogin: writing its token cache failed before kubectl could return cluster credentials.
Tested with: