-
Notifications
You must be signed in to change notification settings - Fork 664
feat(cli): made i18n command more robust #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Partik <[email protected]>
Signed-off-by: Partik <[email protected]>
|
@maxprilutskiy kindly review this pull request |
Signed-off-by: Partik <[email protected]>
|
Hi @partik03 – thanks for the PR, it's almost perfect! Some feedback:
Wrap the following with try/catch to prevent a single localization failure from breaking the entire localization run: ... and just throw everywhere else (if the config can't be loaded, etc). Let me know if the above doesn't make sense, I'll provide more context! |
|
@maxprilutskiy for what I have understood you want that I should consider throwing error every time and stop the execution on the first error (if I consider Am I correct? |
|
@partik03 ah I see what you mean!
While this is not VERY obvious, this improves the developer experience significantly, given the feedback we receive. :) Let me know if the above makes sense! |
|
@maxprilutskiy got it! |
Signed-off-by: Partik <[email protected]>
…exica into i18n-cli-detailing
Signed-off-by: Partik <[email protected]>
Signed-off-by: Partik <[email protected]>
Signed-off-by: Partik <[email protected]>
|
@maxprilutskiy I have completed the desired changes |
maxprilutskiy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job
| --- | ||
| --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this empty changesets file can be now safely removed, since you've added a meaningful changeset message
| .option('--force', 'Ignore lockfile and process all keys') | ||
| .option('--verbose', 'Show verbose output') | ||
| .option('--api-key <api-key>', 'Explicitly set the API key to use') | ||
| .option('--strict', 'Stop on first error') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving the concept!
* feat(cli): made i18n command more robust Signed-off-by: Partik <[email protected]> * Delete pnpm-lock.yaml * fix: pnpm-lock.yaml change Signed-off-by: Partik <[email protected]> * fix: changesets added Signed-off-by: Partik <[email protected]> * fix: revert the lock file Signed-off-by: Partik <[email protected]> * fix: revert the lock file Signed-off-by: Partik <[email protected]> * fix: revert the lock file Signed-off-by: Partik <[email protected]> --------- Signed-off-by: Partik <[email protected]> Co-authored-by: Max Prilutskiy <[email protected]>
Should close #185