fix: babel CJS/ESM in the compiler #1637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrcprl
approved these changes
Nov 25, 2025
vrcprl
changed the title
vrcprl
approved these changes
Nov 26, 2025
The-Best-Codes
pushed a commit
to The-Best-Codes/lingo.dev
that referenced
this pull request
Dec 3, 2025
* WIP * chore: fix types * chore: add changeset --------- Co-authored-by: Veronica Prilutskaya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1636
Babel still ships the older CJS, and when importing it from ESM or CJS the imported value differs.
There is a wait to import with
.defaultimport * as traverse from "@babel/traverse"in node as well, but then TS is not happy, so the more hacky but robust fix is to reexport the functions correctly checking the way it's imported in runtimeChanges
Testing
Business logic tests added:
Visuals
Required for UI/UX changes:
Checklist
Closes #[issue-number]