Skip to content

fix: replace NaN% with 0.0% when all translations complete #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lokyaan wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: replace NaN% with 0.0% when all translations complete #1318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f61594b
fix: replace NaN% with 0.0% when all translations complete
lokyaan Oct 29, 2025
cc0f4e9
fix(cli): prevent NaN% by returning 0.0 when totalWordsToTranslate is 0
lokyaan Oct 30, 2025
a930dfe
chore(package): remove unnecessary build dependency from package.json
lokyaan Oct 31, 2025
e20a46e
chore(deps): update pnpm lockfile
lokyaan Oct 31, 2025
6828767
chore(format): modified status.ts
lokyaan Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/cli/src/cli/cmd/status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,10 @@ export default new Command()
console.log(`• Per-language breakdown:`);
for (const locale of targetLocales) {
const words = totalWordCount.get(locale) || 0;
const percent = ((words / totalWordsToTranslate) * 100).toFixed(1);
const percent =
totalWordsToTranslate === 0
? 0.0
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ternary operator has a type inconsistency. The true branch returns 0.0 (a number), while the false branch returns the result of .toFixed(1) (a string). This should be "0.0" (a string) to match the type returned by .toFixed(1).

const percent =
  totalWordsToTranslate === 0
    ? "0.0"
    : ((words / totalWordsToTranslate) * 100).toFixed(1);
Suggested change
? 0.0
? "0.0"

Copilot uses AI. Check for mistakes.
: ((words / totalWordsToTranslate) * 100).toFixed(1);
console.log(
` - ${locale}: ~${words.toLocaleString()} words (${percent}% of total)`,
);
Expand Down
16 changes: 8 additions & 8 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading