You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey! I am trying to use LndClient to do real-time payment streaming with a static AMP invoice. I ran into two issues using lndclient v0.16.0.
Support for AMP payments does not seem to be built out yet in the AddInvoice method. Notably, the IsAmp field is not properly set in the lnrpc.Invoice object.
Zero value invoices are not properly supported in the SendPayment method. Currently, a Value is only forwarded if the Invoice is not set. Ideally, we would forward the Value independently of whether the Invoice is set to enable zero-value invoices.
Hey. I agree with the IsAmp flag, that needs to be added to the AddInvoice call. Though I'm not sure about the Amt field. It might be confusing to always add the value, especially if it gets overwritten if an invoice is also passed in.
How about we add a new field to the SendPaymentRequest called AmpAmount that is only set if the invoice has a zero amount. Would that work for your use case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
in
lnd_services.goare updated.macaroon_recipes.goif your PR adds a new method that is calleddifferently than the RPC method it invokes.