Fix: remove dataset link by l-mansouri · Pull Request #368 · lifebit-ai/cloudos-cli

l-mansouri · 2026-06-30T14:42:19Z

Overview

This PR removes the datasets link command and removes support for the v1 linking endpoint that got deprecated.

JIRA

Please add here as many related tasks this PR covers with its brief description, if more than one ticket

LP-112583

Changes

Removes cloudos datasets link command and support for a deprecated endpoint

Acceptance Criteria

Please add here as many scenarios as in the Story

Normally this acceptance criteria is tested in ADAPT workspace in PROD

Scenario 1: Command is no longer available

Scenario 2: User is guided to the supported alternatives

Scenario 3: Other datasets subcommands remain functional

Scenario 4: Help text and docs are clean

Copilot

Pull request overview

This PR removes the deprecated cloudos datasets link CLI subcommand (and its documentation) and bumps the CLI patch version accordingly, steering users toward cloudos interactive-session link / --link alternatives.

Changes:

Removed the cloudos datasets link command implementation from the datasets CLI module.
Updated README to remove datasets link documentation and point users to the supported linking commands.
Bumped version to 2.94.2 and added release notes to the changelog.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

File	Description
README.md	Removes `datasets link` documentation and replaces it with guidance to `interactive-session link` / `--link`.
cloudos_cli/datasets/cli.py	Deletes the `datasets link` command implementation (and related import).
cloudos_cli/_version.py	Bumps package version to `2.94.2`.
CHANGELOG.md	Adds a `v2.94.2` entry describing removal of `datasets link`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

danielboloc

LGTM

Only some doubts:

When I do cloudos datasets link --help shouldn't we also add the deprecation error?
I would remove the Usage: cloudos datasets link [OPTIONS] if possible from click

l-mansouri · 2026-07-02T08:29:22Z

@danielboloc thanks for the comment! I have updated the behaviour

l-mansouri added 2 commits June 30, 2026 15:27

removed command

1354ccf

changelog

55d0a87

Copilot AI review requested due to automatic review settings June 30, 2026 14:42

depreacted /v1/interactive-sessions/{sessionId}/fuse-filesystem/mount

0f7c073

Copilot started reviewing on behalf of l-mansouri June 30, 2026 14:42 View session

l-mansouri marked this pull request as draft June 30, 2026 14:45

l-mansouri marked this pull request as ready for review June 30, 2026 14:45

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread CHANGELOG.md

fixed readme

1fc37ca

l-mansouri requested a review from Copilot June 30, 2026 14:47

Copilot started reviewing on behalf of l-mansouri June 30, 2026 14:48 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread cloudos_cli/datasets/cli.py

Comment thread tests/test_datasets/test_link_files.py

Comment thread CHANGELOG.md

address copilot

90d1bfb

l-mansouri marked this pull request as draft June 30, 2026 15:15

l-mansouri marked this pull request as ready for review June 30, 2026 15:15

l-mansouri requested a review from Copilot June 30, 2026 15:29

Copilot started reviewing on behalf of l-mansouri June 30, 2026 15:29 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread cloudos_cli/interactive_session/link.py Outdated

Comment thread cloudos_cli/interactive_session/link.py Outdated

Apply suggestions from code review

94bd132

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

l-mansouri requested a review from Copilot June 30, 2026 15:43

Copilot started reviewing on behalf of l-mansouri June 30, 2026 15:43 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread cloudos_cli/interactive_session/link.py Outdated

Comment thread README.md Outdated

address copilot

29f2539

l-mansouri requested a review from Copilot June 30, 2026 15:49

Copilot started reviewing on behalf of l-mansouri June 30, 2026 15:50 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread cloudos_cli/interactive_session/link.py Outdated

Comment thread cloudos_cli/datasets/cli.py Outdated

address copilot

4b29865

l-mansouri requested a review from Copilot June 30, 2026 15:57

Copilot started reviewing on behalf of l-mansouri June 30, 2026 15:58 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread tests/test_datasets/test_link.py

Comment thread cloudos_cli/interactive_session/link.py Outdated

address copilot

ac9ea91

l-mansouri requested a review from Copilot June 30, 2026 16:06

Copilot started reviewing on behalf of l-mansouri June 30, 2026 16:07 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread cloudos_cli/datasets/cli.py

Comment thread cloudos_cli/interactive_session/link.py Outdated

Comment thread README.md Outdated

l-mansouri and others added 3 commits July 1, 2026 09:12

address copilot

da8a5f9

address copilot

ebcbea2

Potential fix for pull request finding

2c0862b

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

l-mansouri requested a review from Copilot July 1, 2026 07:57

Copilot started reviewing on behalf of l-mansouri July 1, 2026 07:57 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

danielboloc reviewed Jul 2, 2026

View reviewed changes

address danis review

e924d92

l-mansouri marked this pull request as draft July 2, 2026 08:29

l-mansouri marked this pull request as ready for review July 2, 2026 08:29

Uh oh!

Conversation

l-mansouri commented Jun 30, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

JIRA

Changes

Acceptance Criteria

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

danielboloc left a comment

Choose a reason for hiding this comment

Uh oh!

l-mansouri commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

l-mansouri commented Jun 30, 2026 •

edited by atlassian Bot

Loading