Conversation
…0) (#145) Adds a verbose toggle (`v`) for the sysstat/pgstat top panels: sysstat +3 rows (iostat/nicstat/filesyst), pgstat +5 rows (workload/databases/workers/ replication/bgwr-ckpt). A display mode (no new view), reusing the free-form render path, persistent across screens. Includes verbose-gated all-three system collection, verboseCollectState (first-tick n/a + collecting hint + re-arm without Reset, latency guard max(refresh/4,500ms)), new formatters (ceil/reserved-digit/dynamic unit suffix), and panel-consistent aggregates. Full go test ./... green (live PG 14-18), gosec clean. TUI-only (NotRecordable). Decision history under docs/features/010-feat-overview-dashboard/. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ch debt, metrics, archive Post-merge finalization of the verbose-panel feature (merged via PR #145): - project-knowledge: verbose-mode capability (overview), Verbose Top-Panel Mode architecture subsection, 4 reusable patterns. - features-catalog: [010] entry. - decisions-log: 8 ADRs (mode-not-view, dual-boolean, topBandLayout, all-three branch, verboseCollectState re-arm, .ready backlog, databases split, latency guard). - tech-debt: [010]-[015] (recovery-t substitution, rateField/RateUnit dup, Size-field width, golangci-lint v1/v2, tracked bin/pgcenter, GO-2026-5037). - user-spec Post-implementation section; metrics finalized + copied to docs/metrics/; feature dir archived. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
revive redefines-builtin-id flagged local vars `max` (Go 1.21+ builtin) in pretty.RateUnit and top.rateField, and `real` (complex builtin) in an fsstat test. Rename to maxFit / realPath. No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
develop→master. Single feature since the 009 release.Feature 010 — verbose mode for the top summary panels
Adds a verbose toggle (
v) for thesysstat/pgstattop panels ofpgcenter top: sysstat +3 rows (iostat/nicstat/filesyst), pgstat +5 rows (workload/databases/workers/replication/bgwr-ckpt). A display mode (not a new view → zero view-count impact), reusing the free-form render path, persistent across screens, keeping the expanded instance-health summary above any detailed table. Differentiator vs pg_activity: works over remote connections (PL/Perl) and travels with the DBA across screens.Internals: verbose-gated all-three system collection (after the untouched mutually-exclusive collectExtra switch),
verboseCollectState(first-tickn/a+collecting...hint + re-arm without Reset, latency guardmax(refresh/4, 500ms)throttling only the dear no-twin aggregates to a stale value), new aggregate SQL ininternal/query/overview.go, new formatters (ceil / reserved-digit / dynamic unit suffix), panel-consistent values (reuse of%util/Pused/struct math, nicstat/1024/128parity).Merged into develop via #145.
Verification
go test ./...green (race+coverage, live PG 14–18, 0 FAIL/0 SKIP);gosec0 issues;go vet/gofmtclean. golangci-lint runs in CI.NotRecordable). Visual acceptance passed (geometry, panel consistency, first-tick/stale, formatting).Notes for release
tWAL standby path verified by substitution only (no standby cluster). See ADR log [010-feat-overview-dashboard] and tech-debt [010]-[015].🤖 Generated with Claude Code