Skip to content

Conversation

@jfaz1
Copy link
Contributor

@jfaz1 jfaz1 commented May 5, 2025

Closes #1800

It seems that when meta is pressed with an alphanumeric key, SDL2-compat still generates TEXTINPUT events (unlike native SDL2). This PR makes meta key combinations work again with SDL2-compat.

@nassir90
Copy link

nassir90 commented May 5, 2025

This resolved the issue

@SequentialDesign
Copy link
Contributor

nice. meta key works again

@vindarel
Copy link
Collaborator

vindarel commented May 9, 2025

for me on the same old-ish LinuxMint:

it changes something but it's buggy anyways:

  • without: I can't type Meta-( to get [ in SDL2 (ok in ncurses) and Lem says "key not found: Alt-["

  • with the PR: Lem understands it's C-u, so because my "(" is on the 4 key it understands C-u 4.

  • without: I can type Alt-~ + n to get ñ

  • with it: when I type Alt-~ Lem says "Key not found: M-n" and then I press "n" and I do get "ñ".

@jfaz1 jfaz1 marked this pull request as draft May 9, 2025 15:25
@jfaz1
Copy link
Contributor Author

jfaz1 commented May 9, 2025

I thought I tried on standard SDL2, but looks like the one I built wasn't used by Lem and it just used my system one 😮‍💨

In other words, not suitable to merge.

I think the question is whether it's a bug with SDL2-compat and we should open an issue there, or whether it's something on our end or we can make a hotfix. In the meantime I'll leave this PR up so those on SDL2-compat have a way to deal with it.

Pinging President @cxxxr for his opinion 🫡

@cxxxr
Copy link
Member

cxxxr commented Aug 10, 2025

Let's deprecated lem-sdl2

@cxxxr cxxxr closed this Aug 10, 2025
@mantacid
Copy link

If it means anything, I was able to fix the key issue by replacing sdl2-compat with sdl2.

@novemberist
Copy link

Why was this fix never merged? As far as I can tell it works as intended with sdl2-compat.

But I guess it doesn't matter anymore since sdl2 was deprecated.

@ethanxxxl
Copy link
Contributor

I think this PR should be merged, it fixes the issue (I tested on arch linux with and without sdl2-compat). Even though SDL2 is deprecated, if some motivated individual wants to play around with it, we might as well have known working code merged.

perhaps @cxxxr would reconsider this merge?

@cxxxr
Copy link
Member

cxxxr commented Jan 3, 2026

Indeed, I think merging would be fine.

@cxxxr cxxxr reopened this Jan 3, 2026
@cxxxr cxxxr marked this pull request as ready for review January 3, 2026 17:24
@cxxxr cxxxr merged commit 3d8ae25 into lem-project:main Jan 3, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Meta modifier only works on alphanumeric keys in combination with Control

8 participants