feat(confluence): add relation-level reduction inclusions#719
Open
JJYYY-JJY wants to merge 2 commits into
Open
feat(confluence): add relation-level reduction inclusions#719JJYYY-JJY wants to merge 2 commits into
JJYYY-JJY wants to merge 2 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5f19b050e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
chenson2018
reviewed
Jul 16, 2026
| refine Iff.intro ?chain_redex ?redex_chain <;> intros h <;> induction h <;> try rfl | ||
| case redex_chain redex chain => exact ReflTransGen.tail chain (step_to_para redex) | ||
| case chain_redex para redex => exact ReflTransGen.trans redex (para_to_redex para) | ||
| theorem parachain_iff_redex : M ↠ₚ N ↔ M ↠βᶠ N := |
Collaborator
There was a problem hiding this comment.
Maybe for consistency this should now be stated as (· ↠ₚ ·) = (· ↠βᶠ ·) and given a better consistent name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restates four reduction inclusions as namespaced relation inequalities. Pointwise use remains available through dot notation without duplicate wrapper theorems.
This intentionally removes the old pointwise theorem names; there were no in-repository callers.
Closes #696.
Zulip chat
Codex was used for part of the code, I have reviewed all the changes done by it.