-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Added Menu Documentation #7087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added Menu Documentation #7087
Conversation
Signed-off-by: SplinterSword <[email protected]>
|
🚀 Preview for commit dc7b087 at: https://69020a273f76e561f896dff0--layer5.netlify.app |
Rajesh-Nagarajan-11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflicts
|
🚀 Preview for commit 07e42b5 at: https://6905b1688bc7258e811521e3--layer5.netlify.app |
|
Thank you for your contribution! |
Signed-off-by: SplinterSword <[email protected]>
07e42b5 to
1be5b10
Compare
|
🚀 Preview for commit 43ff4d9 at: https://69098cc21ecbee4a0fcff53f--layer5.netlify.app |
|
🚀 Preview for commit 43ff4d9 at: https://69098d2c3c5fb83dce5b8ce4--layer5.netlify.app |
Signed-off-by: SplinterSword <[email protected]>
|
🚀 Preview for commit ee8732c at: https://69099d255618fb4f3e5010fe--layer5.netlify.app |
|
Y all drop-down of menu's not sticky ? @SplinterSword |
|
@Rajesh-Nagarajan-11 do you mean that the drop down menu does down with the scroll ?? |
|
I have just used the code given in the MUI library, so I don't know what is causing this. But I did notice that when the menu is opened in the MUI library, it is just disabling the scroll. |
|
If you want I can disable the scroll till the menu is closed ?? |
|
if the menu dropdown is by default no sticky in the sense , leave here and open a issue for that in sistent |
|
Okay @Rajesh-Nagarajan-11 |
|
🚀 Preview for commit 88f65ec at: https://69158f6f9606eac6c317490f--layer5.netlify.app |
|
Please resolve merge conflicts |
Signed-off-by: Sparsh Jain <[email protected]>
|
🚀 Preview for commit 3893d4d at: https://691aac8cbb995953c1fb33eb--layer5.netlify.app |
|
https://github.com/layer5io/sistent/pull/1185/files With the competition of following PR finally we can merge this, I am testing the sistent changes with other site as well |
|
Okay sure, But it seems the recent changes from the master cause the build to break let me fix this as well. |
|
Also @Namanv0509, if any changes are needed, I will be happy to help |
|
🚀 Preview for commit 68ef6b0 at: https://692d306de33d1d784cf89f2d--layer5.netlify.app |
|
@SplinterSword |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of UX issues I noticed: the menu is not sticky with the page, so when the user scrolls the open menu moves with the content instead of staying anchored to the trigger. Also, when the menu is open it makes the navbar disappear. On the Pricing page the same component behaves correctly, so this seems specific to the new Menu documentation implementation rather than the underlying Menu component itself.
Works fine in the pricing page:
The navbar disappears:
Here the navbar is back:
The menu is not sticky:
|
I fixed the scroll issue with this sistent PR |
|
I will investigate the disappearing NavBar. |
|
@SplinterSword |
|
Ohh okay i didn't realise i fixed two problems at once |
Description
This PR fixes #5952
Notes for Reviewers



Signed commits