Skip to content

Conversation

@SplinterSword
Copy link
Contributor

@SplinterSword SplinterSword commented Oct 29, 2025

Description

This PR fixes #5952

Notes for Reviewers
image
image
image

Signed commits

  • Yes, I signed my commits.

Signed-off-by: SplinterSword <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 29, 2025

🚀 Preview for commit dc7b087 at: https://69020a273f76e561f896dff0--layer5.netlify.app

Copy link
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts

@l5io
Copy link
Contributor

l5io commented Nov 1, 2025

🚀 Preview for commit 07e42b5 at: https://6905b1688bc7258e811521e3--layer5.netlify.app

@Rajesh-Nagarajan-11
Copy link
Member

Thank you for your contribution!
Let’s discuss this during the website call tomorrow (November 3) at 5:30 PM IST | 7:00 AM CT.
Please add it as an agenda item to the meeting minutes
😊

Signed-off-by: SplinterSword <[email protected]>
@l5io
Copy link
Contributor

l5io commented Nov 4, 2025

🚀 Preview for commit 43ff4d9 at: https://69098cc21ecbee4a0fcff53f--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Nov 4, 2025

🚀 Preview for commit 43ff4d9 at: https://69098d2c3c5fb83dce5b8ce4--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Nov 4, 2025

🚀 Preview for commit ee8732c at: https://69099d255618fb4f3e5010fe--layer5.netlify.app

@Rajesh-Nagarajan-11
Copy link
Member

Y all drop-down of menu's not sticky ? @SplinterSword

@SplinterSword
Copy link
Contributor Author

@Rajesh-Nagarajan-11 do you mean that the drop down menu does down with the scroll ??

@SplinterSword
Copy link
Contributor Author

I have just used the code given in the MUI library, so I don't know what is causing this. But I did notice that when the menu is opened in the MUI library, it is just disabling the scroll.

@SplinterSword
Copy link
Contributor Author

If you want I can disable the scroll till the menu is closed ??

@Rajesh-Nagarajan-11
Copy link
Member

if the menu dropdown is by default no sticky in the sense , leave here and open a issue for that in sistent

@SplinterSword
Copy link
Contributor Author

Okay @Rajesh-Nagarajan-11

@l5io
Copy link
Contributor

l5io commented Nov 13, 2025

🚀 Preview for commit 88f65ec at: https://69158f6f9606eac6c317490f--layer5.netlify.app

@Rajesh-Nagarajan-11
Copy link
Member

Please resolve merge conflicts

@l5io
Copy link
Contributor

l5io commented Nov 17, 2025

🚀 Preview for commit 3893d4d at: https://691aac8cbb995953c1fb33eb--layer5.netlify.app

@Namanv0509
Copy link
Contributor

https://github.com/layer5io/sistent/pull/1185/files With the competition of following PR finally we can merge this, I am testing the sistent changes with other site as well

@SplinterSword
Copy link
Contributor Author

Okay sure, But it seems the recent changes from the master cause the build to break let me fix this as well.

@SplinterSword
Copy link
Contributor Author

Also @Namanv0509, if any changes are needed, I will be happy to help

@l5io
Copy link
Contributor

l5io commented Dec 1, 2025

🚀 Preview for commit 68ef6b0 at: https://692d306de33d1d784cf89f2d--layer5.netlify.app

@kishore08-07
Copy link
Contributor

@SplinterSword
Thank you for your contribution!
Let's discuss this during the website call today at 6:30 PM IST | 8 AM CT
Add it as an agenda item to the meeting minutes, if you would 🙂

@Fireentity Fireentity self-requested a review December 4, 2025 11:31
Copy link
Contributor

@Fireentity Fireentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of UX issues I noticed: the menu is not sticky with the page, so when the user scrolls the open menu moves with the content instead of staying anchored to the trigger. Also, when the menu is open it makes the navbar disappear. On the Pricing page the same component behaves correctly, so this seems specific to the new Menu documentation implementation rather than the underlying Menu component itself.

Works fine in the pricing page:

Image

The navbar disappears:

Image

Here the navbar is back:

Image

The menu is not sticky:

Image

@SplinterSword
Copy link
Contributor Author

I fixed the scroll issue with this sistent PR

@SplinterSword
Copy link
Contributor Author

I will investigate the disappearing NavBar.

@Fireentity
Copy link
Contributor

@SplinterSword
The reason why the navbar disappears is that the modification added in the PR layer5io/sistent#1185 is not here. This PR layer5io/sistent#1185 does solve also the problem with the navbar. I will check later if there are other problems, otherwise I will leave a LGTM.

@SplinterSword
Copy link
Contributor Author

Ohh okay i didn't realise i fixed two problems at once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sistent] Add Menu component to the sistent components page

8 participants