[servarr] fix: decouple /media mount from jellyfin.enabled#69
Open
cgrard wants to merge 1 commit into
Open
Conversation
The *arr containers (sonarr, radarr, lidarr, bazarr, qbittorrent,
cleanuparr) only mount their shared /media volume when both
jellyfin.enabled and jellyfin.persistence.media.enabled are true.
This means operators who don't run Jellyfin from this chart must
keep a "ghost" jellyfin.enabled=true with replicaCount=0 just to
get /media wired into the other apps.
Introduce a top-level sharedMedia key that gates the /media mount
independently:
sharedMedia:
enabled: false
existingClaim: ""
When sharedMedia.enabled=true and sharedMedia.existingClaim is set,
every *arr container mounts /media from that claim, whether or not
Jellyfin is enabled.
Backwards compatibility: the legacy jellyfin.enabled +
jellyfin.persistence.media.enabled path is preserved as a second
branch inside the new helpers. Existing deployments render byte-for-
byte identically (verified with helm template diff).
Two helpers were added in templates/_helpers.tpl to keep the
per-app conditions concise and consistent:
- servarr.mediaEnabled -> truthy when either mechanism is active
- servarr.mediaClaimName -> resolves the PVC name to mount
Chart version bumped 1.5.2 -> 1.5.3 (patch: bug fix, no user-visible
breakage).
Signed-off-by: Cédric <cedric.grard@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The *arr containers (sonarr, radarr, lidarr, bazarr, qbittorrent, cleanuparr) only mount their shared /media volume when both jellyfin.enabled and jellyfin.persistence.media.enabled are true. This means operators who don't run Jellyfin from this chart must keep a "ghost" jellyfin.enabled=true with replicaCount=0 just to get /media wired into the other apps.
Introduce a top-level sharedMedia key that gates the /media mount independently:
sharedMedia:
enabled: false
existingClaim: ""
When sharedMedia.enabled=true and sharedMedia.existingClaim is set, every *arr container mounts /media from that claim, whether or not Jellyfin is enabled.
Backwards compatibility: the legacy jellyfin.enabled + jellyfin.persistence.media.enabled path is preserved as a second branch inside the new helpers. Existing deployments render byte-for- byte identically (verified with helm template diff).
Two helpers were added in templates/_helpers.tpl to keep the per-app conditions concise and consistent:
Chart version bumped 1.5.2 -> 1.5.3 (patch: bug fix, no user-visible breakage).
Kubito Helm Charts PR Checklist
Thank you for your contribution! Please ensure the following:
[] Chart Version: Updated
versioninChart.yamlfor the relevant chart.[] README Update: If
values.yamlwas changed, run:[] Testing: Tested the chart locally, and it works as expected.
Changes Summary
Related Issues