Conversation
Author
|
@Zen-CODE This is ready to be checked. |
Member
|
Thanks for this. It's a nice PR, and I appreciate the consideration for backwards compatibility +1 |
Author
|
You're welcome! |
|
@Zen-CODE what about the fix to the camera module ? it is not working on android anymore |
|
@franccisco Is there any way to use this important commit with buildozer without waiting for a new plyer version ? |
Member
|
@tomgold182 Yes. In your requirements, instead of just "plyer", point it to the github repo using the master branch. Google should tell you how to do that: it's just like a pip requirement. With regards to the camera fix, that would be great. You are welcome to submit a PR fixing that. |
Member
|
@tomgold182 Can you confirm that it works for you? |
|
@Zen-CODE Will check soon and let you know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #501 #509
In this PR I implemented a solution considering the deprecations applied since API 26 (check https://developer.android.com/reference/android/os/Vibrator). In order to make the vibration work again, I had to first use jnius.cast with "android.os.Vibrator" and VIBRATOR_SERVICE.
Since API 26, the VIbrationEffect class admits different types of vibrations, but I just implemented https://developer.android.com/reference/android/os/VibrationEffect.html#createOneShot(long,%20int) and https://developer.android.com/reference/android/os/VibrationEffect.html#createWaveform(long[],%20int), otherwise I could break plyer's VIbrator API.
This PR has been already tested. Anyway, I invite you to try it and post the results.