Improvements I made on my end #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess) of a connected client (or the listen interface of a server)
…nd ip-addresses of the host machine
- Split sts_net_open_socket into sts_net_listen (server) and sts_net_connect (client) - Changed socket set to contain sockets not user managed pointer to sockets - Added sts_net_get_available_socket_from_set which returns a socket for accepting - Added sts_net_drop_socket which can be used to drop a new connection if no socket is available - Removed sts_net_add_socket_to_set and sts_net_remove_socket_from_set as it is now automatic! - Updated example
fix source formatting
added want_local_name to sts_net_gethostname added share_port option to sts_net_listen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I made some improvements/changes to sts_net and was wondering if you're interested.
It's mostly fixes (build improvements, etc.) and optional additional functions (get the host name or ip of a connected client and enumerate host machine network interfaces), but there's one bigger change.
Commit 47a53d4 changes how sts_net_set_t handles sockets. Instead of having the user code manage an array of sockets itself I thought it would be easier and more useful to have the sockets right in there. This removes the need adding/removing them manually. I added get_available_socket_from_set which returns an available socket and sts_net_drop_socket which can be used instead of accept_socket in case the set is full.
See the updated example of how these changes can be used.
If you're only interested in a subset of these I can prepare a new branch+pull request.
Cheers