Metrics: keep chrome essentials on histogram failure, gate PID walk on deadline#313
Draft
sjmiller609 wants to merge 1 commit into
Draft
Metrics: keep chrome essentials on histogram failure, gate PID walk on deadline#313sjmiller609 wants to merge 1 commit into
sjmiller609 wants to merge 1 commit into
Conversation
A UMA histogram fetch failure now logs and skips only the histogram family instead of discarding the whole chrome scrape — the up, info, and pages samples survive, so browser-up alerting keeps its signal. The system collector checks the scrape deadline before starting the /proc PID walk. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups to two review findings that landed after #309 merged:
kernel_chromium_up/info/pagessamples and hiding the browser-up signal exactly when the browser was struggling./procPID walk, so an expired scrape doesn't begin new work while holding the scrape lock.Test plan
TestChromeCollectorHistogramFailure: essentials survive, UMA family absentgo vet+ full unit suite pass🤖 Generated with Claude Code