add 'none' as an option for reasoning effort, update models across#2227
Merged
Conversation
…oviders Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #2226 by allowing reasoningEffort: none in ModelConfig (enabling OpenAI Chat Completions tool-calling for models that require disabling reasoning) and refreshes the backend “supported models” list exposed to the UI/API.
Changes:
- Add
"none"as a validreasoningEffortvalue in the ModelConfig CRD schema (Go types + generated CRDs + Helm CRDs). - Update internal supported model lists across multiple providers (notably adding
gpt-5.6-*models). - Update architecture docs to reflect the new
reasoningEffortoption.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| helm/kagent-crds/templates/kagent.dev_modelconfigs.yaml | Adds none to the CRD enum for reasoningEffort in the Helm-distributed CRDs. |
| go/core/internal/httpserver/handlers/models.go | Expands/refreshes the supported model lists returned by the models API endpoint. |
| go/api/v1alpha2/modelconfig_types.go | Extends kubebuilder enum to include none and documents why it’s needed for certain OpenAI models. |
| go/api/config/crd/bases/kagent.dev_modelconfigs.yaml | Adds none to the generated CRD base schema enum for reasoningEffort. |
| docs/architecture/crds-and-types.md | Documents reasoningEffort: none in the CRD/type overview. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EItanya
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2226 by adding 'none' to the reasoning effort and updates the model list.