Skip to content

add 'none' as an option for reasoning effort, update models across#2227

Merged
EItanya merged 2 commits into
mainfrom
peterj/supportterra
Jul 14, 2026
Merged

add 'none' as an option for reasoning effort, update models across#2227
EItanya merged 2 commits into
mainfrom
peterj/supportterra

Conversation

@peterj

@peterj peterj commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

fixes #2226 by adding 'none' to the reasoning effort and updates the model list.

…oviders

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Copilot AI review requested due to automatic review settings July 13, 2026 15:30
@peterj
peterj requested a review from a team as a code owner July 13, 2026 15:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #2226 by allowing reasoningEffort: none in ModelConfig (enabling OpenAI Chat Completions tool-calling for models that require disabling reasoning) and refreshes the backend “supported models” list exposed to the UI/API.

Changes:

  • Add "none" as a valid reasoningEffort value in the ModelConfig CRD schema (Go types + generated CRDs + Helm CRDs).
  • Update internal supported model lists across multiple providers (notably adding gpt-5.6-* models).
  • Update architecture docs to reflect the new reasoningEffort option.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
helm/kagent-crds/templates/kagent.dev_modelconfigs.yaml Adds none to the CRD enum for reasoningEffort in the Helm-distributed CRDs.
go/core/internal/httpserver/handlers/models.go Expands/refreshes the supported model lists returned by the models API endpoint.
go/api/v1alpha2/modelconfig_types.go Extends kubebuilder enum to include none and documents why it’s needed for certain OpenAI models.
go/api/config/crd/bases/kagent.dev_modelconfigs.yaml Adds none to the generated CRD base schema enum for reasoningEffort.
docs/architecture/crds-and-types.md Documents reasoningEffort: none in the CRD/type overview.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@EItanya
EItanya merged commit 73fd76b into main Jul 14, 2026
31 checks passed
@EItanya
EItanya deleted the peterj/supportterra branch July 14, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Cant use gpt-5.6

3 participants