fixes empty secretkeyref in azureopenai#2225
Open
peterj wants to merge 2 commits into
Open
Conversation
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in the Agent ADK API translator where the AzureOpenAI branch could inject an AZURE_OPENAI_API_KEY env var backed by a secretKeyRef with an empty Secret name when apiKeySecret was unset (e.g., when authenticating via azureADToken).
Changes:
- Add the missing
model.Spec.APIKeySecret != ""guard to the AzureOpenAI API-key env var injection logic. - Add a regression unit test to ensure no AzureOpenAI API-key Secret ref env var is injected when
apiKeySecretis unset andazureADTokenis used.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/core/internal/controller/translator/agent/adk_api_translator.go | Prevents injecting an invalid secretKeyRef for AzureOpenAI when apiKeySecret is empty. |
| go/core/internal/controller/translator/agent/adk_api_translator_test.go | Adds a regression test covering AzureOpenAI auth via azureADToken with no apiKeySecret. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2212