feat(bedrock): configurable Bedrock read/connect timeout

[go-faustino]

Summary

The Python ADK's Bedrock client is created with boto3.client("bedrock-runtime", ...) and no botocore Config, so it uses botocore's ~60s default read timeout. Long Converse completions — large tool-augmented turns, extended reasoning — are aborted mid-response with a ReadTimeoutError, surfaced to the user as an API error.

This adds an optional, configurable Bedrock read timeout (and connect timeout), plumbed end to end from the ModelConfig CRD down to the boto3 client.

Changes

• _bedrock.py: _get_bedrock_client now accepts read_timeout / connect_timeout and builds a botocore.config.Config only when at least one is set, so the default behavior is unchanged. KAgentBedrockLlm exposes the two fields and forwards them.
• types.py: the Bedrock model config gains read_timeout / connect_timeout, passed into KAgentBedrockLlm.
• CRD: BedrockConfig gains readTimeout / connectTimeout (seconds, minimum: 1), mapped through the Go adk.Bedrock type and the agent translator. CRD manifest and the Helm kagent-crds copy regenerated with controller-gen.

Test

Adds Python unit tests in tests/unittests/models/test_bedrock.py:

• no config passed when timeouts are unset (default preserved),
• read_timeout sets Config.read_timeout (connect left at botocore's default),
• read_timeout + connect_timeout both applied.

uv run pytest tests/unittests/models/test_bedrock.py -q
36 passed

Go: go build ./api/... ./core/internal/controller/translator/... and go vet ./api/... pass; deepcopy regenerated.

Example

apiVersion: kagent.dev/v1alpha2
kind: ModelConfig
spec:
  provider: Bedrock
  model: us.anthropic.claude-sonnet-4-20250514-v1:0
  bedrock:
    region: us-east-1
    readTimeout: 1800   # 30 minutes

[Copilot]

Pull request overview

Adds end-to-end configuration for AWS Bedrock client HTTP connect/read timeouts so long Converse responses aren’t aborted by botocore’s ~60s default read timeout, while preserving existing default behavior when timeouts are unset.

Changes:

• Plumbs readTimeout / connectTimeout from the ModelConfig CRD → Go translator/types → Python ADK model config.
• Updates the Bedrock boto3 client creation to optionally attach a botocore.config.Config only when a timeout override is provided.
• Adds Python unit tests covering the “no config when unset” behavior and the timeout override cases.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
python/packages/kagent-adk/tests/unittests/models/test_bedrock.py	Adds unit tests asserting boto3 client config behavior for unset/set timeouts.
python/packages/kagent-adk/src/kagent/adk/types.py	Extends the Python Bedrock model config schema to include timeout fields and forwards them into Bedrock LLM construction.
python/packages/kagent-adk/src/kagent/adk/models/_bedrock.py	Adds optional read_timeout/connect_timeout plumbing into the Bedrock boto3 client via botocore.config.Config.
helm/kagent-crds/templates/kagent.dev_modelconfigs.yaml	Regenerates Helm CRD template to include Bedrock timeout fields with minimum validation.
go/core/internal/controller/translator/agent/adk_api_translator.go	Maps Bedrock timeout fields from CRD spec into the ADK Bedrock payload.
go/api/v1alpha2/zz_generated.deepcopy.go	Regenerates deepcopy for new BedrockConfig fields.
go/api/v1alpha2/modelconfig_types.go	Adds BedrockConfig readTimeout/connectTimeout with Minimum=1 validation and docs.
go/api/config/crd/bases/kagent.dev_modelconfigs.yaml	Updates the base CRD manifest with Bedrock timeout schema/docs.
go/api/adk/types.go	Extends Go ADK Bedrock type to include timeout fields for JSON payloads.

Files not reviewed (1)

• go/api/v1alpha2/zz_generated.deepcopy.go: Generated file

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[go-faustino]

Good call — fixed in 6c3e7d5. The test no longer hard-codes 60; it now asserts config.connect_timeout == BotocoreConfig().connect_timeout, i.e. against botocore's own current default for the installed version, so it won't break if that default changes.

[go-faustino]

Done in 6c3e7d5. read_timeout / connect_timeout are now Field(default=None, ge=1) on both the Bedrock config type (here) and KAgentBedrockLlm, matching the CRD's minimum: 1. Added tests covering accepted positive values and rejected 0/negative (raises ValidationError).

[go-faustino]

Addressed in 6c3e7d5 by validating at the model boundary rather than inside this private builder. _get_bedrock_client is only reached via KAgentBedrockLlm._client, and KAgentBedrockLlm.read_timeout / connect_timeout are now Field(ge=1) (matching the Bedrock config type and the CRD minimum: 1), so 0/negative values can't reach the botocore Config. I kept this function a thin builder to avoid duplicating the constraint in a third place, but happy to add an explicit guard here too if you'd prefer defense-in-depth for direct callers.