Skip to content

chore(substrate): Bump substrate to v0.0.9 and remove collapsing of image env into actor env#2208

Merged
EItanya merged 7 commits into
mainfrom
chore/bump-substrate
Jul 15, 2026
Merged

chore(substrate): Bump substrate to v0.0.9 and remove collapsing of image env into actor env#2208
EItanya merged 7 commits into
mainfrom
chore/bump-substrate

Conversation

@jmhbh

@jmhbh jmhbh commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Bump substrate to v0.0.9 and fix #2206

jmhbh added 2 commits July 10, 2026 13:02
Signed-off-by: JM Huibonhoa <jm.huibonhoa@solo.io>
Signed-off-by: JM Huibonhoa <jm.huibonhoa@solo.io>
@jmhbh jmhbh marked this pull request as ready for review July 10, 2026 21:32
Copilot AI review requested due to automatic review settings July 10, 2026 21:32
@jmhbh jmhbh requested a review from a team as a code owner July 10, 2026 21:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the kagent Substrate integration to align with substrate v0.0.9, including protobuf/API shape changes (e.g., actor identity/version moving under Metadata) and removing the prior workaround that manually injected image runtime ENV into the ActorTemplate env (per issue #2206).

Changes:

  • Bump github.com/kagent-dev/substrate replace target to v0.0.9 (and update go.sum accordingly).
  • Migrate Substrate client + handlers + tests to the new v0.0.9 API/proto shapes (ObjectRef, ResourceMetadata, updated RPC request/response types).
  • Remove the Python runtime image ENV re-injection (pythonRuntimeImageEnv) now that substrate applies image ENV directives.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
go/go.sum Updates dependency checksums for substrate v0.0.9.
go/go.mod Bumps the substrate replace to github.com/kagent-dev/substrate v0.0.9.
go/core/pkg/sandboxbackend/substrate/openclaw.go Uses metadata-based actor identity/atespace for endpoint display.
go/core/pkg/sandboxbackend/substrate/lifecycle_delete_test.go Updates cleanup-path fakes to match new ControlClient RPC shapes.
go/core/pkg/sandboxbackend/substrate/config_hash_test.go Updates actor test fixtures to use ResourceMetadata{Name: ...}.
go/core/pkg/sandboxbackend/substrate/client.go Migrates substrate client calls to ObjectRef + metadata-based identity and updated RPC signatures.
go/core/pkg/sandboxbackend/substrate/client_test.go Updates CreateAtespace fake to match new request/return types.
go/core/pkg/sandboxbackend/substrate/agentharness_actor.go Switches actor identification from ActorId to metadata name.
go/core/pkg/sandboxbackend/substrate/agent_lifecycle.go Removes Python image ENV injection workaround per substrate v0.0.9 behavior.
go/core/pkg/sandboxbackend/substrate/agent_lifecycle_test.go Updates tests to reflect image ENV no longer being manually re-supplied.
go/core/pkg/sandboxbackend/substrate/agent_actor.go Switches actor identification from ActorId to metadata name.
go/core/internal/httpserver/handlers/substrate.go Updates HTTP API mapping to pull Actor/Worker identity/version from metadata/assignment.
go/core/internal/httpserver/handlers/substrate_test.go Updates handler test fixtures to the new proto shapes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 262 to 263
require.Equal(t, tc.wantConfigEnv, names["KAGENT_CONFIG_JSON"], "declarative agents materialize config from secret env; BYO does not")
require.True(t, names["KAGENT_CONFIG_JSON"], "every agent type gets the rendered config via secret env (BYO decides for itself whether to consume it)")
@EItanya EItanya merged commit 54ded51 into main Jul 15, 2026
31 checks passed
@EItanya EItanya deleted the chore/bump-substrate branch July 15, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tech Debt] Image env no longer needs to be pushed into Actor env for Sandbox Agents

4 participants