fix(frontend,website): make the wizard and docs site usable on a phone#145
Conversation
🦋 Changeset detectedLatest commit: 4d3a56c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Pushed a0242dc with fixes for the review findings, plus one item left deliberately undone. Fixed
Left alone: the conflict with #146 Both PRs are Beyond the textual conflict, #146 removes .cliBlock { overflow-x: auto; }would target a class that no longer exists. I didn't touch it, because the right action depends on merge order and that's yours to pick. If #146 lands first, rebase this branch and drop the Not addressed: the step labels at |
The wizard had no width-based breakpoints, so its fixed 210px step rail left about 165px of content on a 375px screen. Below 700px the rail now becomes a horizontal top bar: the same nodes and connector rotated a quarter turn, each label under its node. The connector reuses the vertical rule's trick — equal width columns and no gap make `left: 50%; width: 100%` land exactly on the next node, the way `height: calc(100% + gap)` did going down. The rest follows from the wider content area: landing cards stack and scroll from the top rather than centering and clipping on a short screen, the preview drawer goes full width now that no side rail constrains it, the Variables description/type pair and the Authors paired fields drop to one column, picker and action rows wrap, and the JSON viewer's per-level indent tightens. Form controls are pinned to 16px on small screens because iOS Safari auto-zooms on any focused control below that size, which left the page zoomed in and scrolled sideways after tapping a field. On the site, the wizard frame and contact page gain dvh units alongside vh so a retractable mobile URL bar doesn't push them past the fold, and the wizard frame stops reserving a single-row footer height that the footer exceeds once it wraps to three rows on a phone. Homepage display type and gutters shrink at 600px, and the footer centers its wrapped rows instead of scattering them under space-between. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…o of them The .previewPill override sat in a media block placed above the base rule. Same specificity, so source order decided and the base won — the pill never moved on a phone. It now sits after the rule it overrides, with a note on why the position matters. The .shell/.content overrides in that block were unaffected (their base rules precede it) and stay where they are. The 16px rule no longer applies to checkboxes and radios. Neither can be zoomed into, so they were never part of the iOS problem being solved, and forcing a font-size on a control that may size itself from one is a risk taken for nothing. The list cap is now 40dvh (40vh retained as the fallback), matching the reasoning applied to the site's viewport heights in this same branch: on a phone the URL bar counts toward vh. The comment also states what the rule is for, since at portrait heights it lands close to the desktop cap and only does visible work in landscape. Also drops a comment reference to --w-narrow, which does not exist. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
a0242dc to
4d3a56c
Compare
|
#146 is merged (ffe5647), so I've rebased this branch onto it and resolved the conflict — force-pushed as 4d3a56c. The conflict resolution. Mandy's authorship is preserved on 2019ce6; only my follow-up fixes sit on top. Checked the rest of the branch for the same problem. Rather than assume
Still not addressed, and still your call: the |
What
The wizard had no width-based breakpoints at all. Its fixed 210px step rail left roughly 165px of usable content on a 375px screen, which made the tool effectively unusable on a phone. This adds a phone layout to the wizard and closes the remaining mobile gaps on the docs site.
The main change
Below 700px the step rail becomes a horizontal top bar — the same nodes and connector rotated a quarter turn, each label under its node. Progress stays visible at every step; nothing moves behind a hamburger.
The connector reuses the vertical rule's existing trick. Going down it was
height: calc(100% + gap)to reach the next node; across, equal-width columns withgap: 0makeleft: 50%; width: 100%land on exactly the same spot.Wizard (
packages/frontend)Sidebar.module.cssmin(320px, 100vw - 2rem)AppShell.module.cssmin-height: 0so it scrolls rather than pushing the shell taller; bottom padding clears the Preview pillindex.cssPreviewDrawer.module.css--sidebar-wallowance is meaningless once the rail is goneLanding.module.cssVariables.module.css1fr 140px→ one column; long column names wrap instead of forcing the row wideAuthors.module.cssDataUpload.module.css40vhProjectInfo.module.cssReview.module.cssJsonViewer.module.cssSite (
website)wizard.module.css—dvhalongsidevh(mobile URL bars count toward100vh, so the frame hung below the fold), and on phones the frame takes the full height below the navbar. The old- 4.5remassumed a single-row footer; it wraps to three rows on a phone, so subtracting it still left the frame overhanging.index.module.css— hero type was still 2.4rem at phone width; trimmed gutters, stacked the card CTAs.Footer/styles.module.css— wrapped items were scattering underspace-between; now centered.contact.module.css—dvh+ tighter padding.Testing
tsc -bclean; lint 0 errors (10 pre-existing warnings, allreact-refresh/exhaustive-deps)npm run buildsucceeds for both the wizard bundle and the Docusaurus site; all 11 media queries confirmed present in the shipped CSSNo behavior or markup changed — this is CSS only, all of it additive inside
@media (max-width: …)blocks, so desktop rendering is untouched.